Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933837AbbFWOMa (ORCPT ); Tue, 23 Jun 2015 10:12:30 -0400 Received: from mail-ob0-f181.google.com ([209.85.214.181]:35036 "EHLO mail-ob0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933809AbbFWOMN convert rfc822-to-8bit (ORCPT ); Tue, 23 Jun 2015 10:12:13 -0400 MIME-Version: 1.0 In-Reply-To: <1435065280.13545.6.camel@localhost> References: <1435065280.13545.6.camel@localhost> From: Alexandre Courbot Date: Tue, 23 Jun 2015 23:11:52 +0900 Message-ID: Subject: Re: [PATCH] gpio/xilinx: Use correct address when setting initial values. To: =?UTF-8?Q?Rapha=C3=ABl_Teysseyre?= Cc: Linus Walleij , Michal Simek , =?UTF-8?Q?S=C3=B6ren_Brinkmann?= , "linux-gpio@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1887 Lines: 50 On Tue, Jun 23, 2015 at 10:14 PM, Raphaël Teysseyre wrote: > From 670209328307a198b80723a917957269a815fc32 Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Rapha=C3=ABl=20Teysseyre?= > Date: Tue, 23 Jun 2015 14:49:31 +0200 > Subject: [PATCH] gpio/xilinx: Use correct address when setting initial values. > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit Mmm this looks like you copy/pasted the output of git format-patch into your email client. Use git send-email instead, or avoid the mail headers if you wish to use another client. > > Signed-off-by: Raphaël Teysseyre A commit message beyond the subject would be appreciated. What did you fix exactly? What was incorrect? > --- > drivers/gpio/gpio-xilinx.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c > index 61243d1..e544b7a 100644 > --- a/drivers/gpio/gpio-xilinx.c > +++ b/drivers/gpio/gpio-xilinx.c > @@ -220,9 +220,9 @@ static void xgpio_save_regs(struct of_mm_gpio_chip *mm_gc) > if (!chip->gpio_width[1]) > return; > > - xgpio_writereg(mm_gc->regs + XGPIO_DATA_OFFSET + XGPIO_TRI_OFFSET, > + xgpio_writereg(mm_gc->regs + XGPIO_DATA_OFFSET + XGPIO_CHANNEL_OFFSET, > chip->gpio_state[1]); > - xgpio_writereg(mm_gc->regs + XGPIO_TRI_OFFSET + XGPIO_TRI_OFFSET, > + xgpio_writereg(mm_gc->regs + XGPIO_TRI_OFFSET + XGPIO_CHANNEL_OFFSET, > chip->gpio_dir[1]); > } > > -- > 1.7.1 > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/