Message-ID: <55896EB5.4030307@sandisk.com>
Date: Tue, 23 Jun 2015 07:35:33 -0700
From: Bart Van Assche <bart.vanassche@sandisk.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Vaishali Thakkar <vthakkar1994@gmail.com>,
        Doug Ledford <dledford@redhat.com>
CC: Sean Hefty <sean.hefty@intel.com>,
        Hal Rosenstock <hal.rosenstock@gmail.com>,
        <linux-rdma@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] IB/srpt: Convert use of __constant_cpu_to_beXX to cpu_to_beXX
References: <20150623044153.GA21400@vaishali-Ideapad-Z570>
In-Reply-To: <20150623044153.GA21400@vaishali-Ideapad-Z570>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2015 14:35:35.9715
 (UTC)
X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d;Ip=[63.163.107.172];Helo=[milsmgep11.sandisk.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0201MB0746
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 705
Lines: 19

On 06/22/15 21:41, Vaishali Thakkar wrote:
>   	if (!slot || slot > 16) {
>   		mad->mad_hdr.status
> -			= __constant_cpu_to_be16(DM_MAD_STATUS_INVALID_FIELD);
> +			= cpu_to_be16(DM_MAD_STATUS_INVALID_FIELD);
>   		return;
>   	}

Without this change several statements exceeded 80 characters and were 
split because of that reason. Please change the multi-line statements 
that have been reduced to less than 80 columns into single-line statements.

Bart.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/