Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932945AbbFWQAv (ORCPT ); Tue, 23 Jun 2015 12:00:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54546 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754852AbbFWQAc (ORCPT ); Tue, 23 Jun 2015 12:00:32 -0400 Message-ID: <5589829B.2050002@redhat.com> Date: Tue, 23 Jun 2015 18:00:27 +0200 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Alex Williamson , "Wu, Feng" CC: "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "mtosatti@redhat.com" , "eric.auger@linaro.org" Subject: Re: [v4 12/16] KVM: kvm-vfio: implement the VFIO skeleton for VT-d Posted-Interrupts References: <1434019912-15423-1-git-send-email-feng.wu@intel.com> <1434019912-15423-13-git-send-email-feng.wu@intel.com> <1434042907.4927.194.camel@redhat.com> <1434120664.4927.289.camel@redhat.com> In-Reply-To: <1434120664.4927.289.camel@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 981 Lines: 25 On 12/06/2015 16:51, Alex Williamson wrote: > > > The code below can't get to this function without > > > __KVM_HAVE_ARCH_KVM_VFIO_POST, but this seems like it should return an > > > error if not implemented. > > > > kvm_arch_vfio_update_pi_irte() is called by kvm_vfio_control_pi(), if we remove the > > dummy definition of kvm_arch_vfio_update_pi_irte(), kvm_vfio_control_pi() is also > > needed to be included in __KVM_HAVE_ARCH_KVM_VFIO_POST, I will handle this > > in the next version. > > But typically we wouldn't return success for a function that's not > implemented. I agree. Moving the implementation to vmx.c would also let you make kvm_arch_update_pi_irte() the only entry-point to the functionality in vmx.c. Paolo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/