Date: Tue, 23 Jun 2015 19:03:35 +0200
From: Oleg Nesterov <oleg@redhat.com>
To: Pavel Emelyanov <xemul@parallels.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        Al Viro <viro@ZenIV.linux.org.uk>, Benjamin LaHaise <bcrl@kvack.org>,
        Hugh Dickins <hughd@google.com>, Jeff Moyer <jmoyer@redhat.com>,
        Kirill Shutemov <kirill.shutemov@linux.intel.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        linux-kernel@vger.kernel.org, Andy Lutomirski <luto@kernel.org>
Subject: Re: vdso && f_op->mremap (Was: special_mapping_fault() is broken)
Message-ID: <20150623170335.GA27256@redhat.com>
References: <20150621210725.GA18220@redhat.com> <20150621211951.GA18593@redhat.com> <20150623004744.GA11212@redhat.com> <5589758B.6030804@parallels.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5589758B.6030804@parallels.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 844
Lines: 28

On 06/23, Pavel Emelyanov wrote:
>
> On 06/23/2015 03:47 AM, Oleg Nesterov wrote:
>
> > Afaics. Still, I think we might want to have special_mapping_remap()
> > and we can't do this because ->vm_file == NULL.
>
> For aio (the single for now mapping with mremap callback) the vm_file
> is not NULL.

I meant, vdso can't hook ->remap because vm_file is NULL.

> > In short. Shouldn't we move ->mremap() to vm_operations_struct before
> > it has another user? We need to fix aio.c, but this is trivial.
> >
> > No?
>
> I will be OK with this change :)

OK, nobody objects, I'll send a patch...

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/