Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932778AbbFWSUf (ORCPT ); Tue, 23 Jun 2015 14:20:35 -0400 Received: from mta-out1.inet.fi ([62.71.2.229]:58434 "EHLO johanna1.rokki.sonera.fi" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932369AbbFWSUQ (ORCPT ); Tue, 23 Jun 2015 14:20:16 -0400 RazorGate-KAS: Rate: 5 RazorGate-KAS: {RECEIVED: dynamic ip detected} RazorGate-KAS: Envelope from: RazorGate-KAS: Version: 5.5.3 RazorGate-KAS: LuaCore: 80 2014-11-10_18-01-23 260f8afb9361da3c7edfd3a8e3a4ca908191ad29 RazorGate-KAS: Method: none RazorGate-KAS: Lua profiles 69136 [Nov 12 2014] RazorGate-KAS: Status: not_detected Date: Tue, 23 Jun 2015 21:19:45 +0300 From: "Kirill A. Shutemov" To: Oleg Nesterov Cc: Andy Lutomirski , Andrew Morton , Al Viro , Benjamin LaHaise , Hugh Dickins , Jeff Moyer , Kirill Shutemov , Linus Torvalds , "linux-kernel@vger.kernel.org" , Andy Lutomirski , Pavel Emelyanov Subject: Re: [PATCH 1/1] mm: move ->mremap() from file_operations to vm_operations_struct Message-ID: <20150623181945.GA13390@node.dhcp.inet.fi> References: <20150623180225.GA12882@redhat.com> <20150623180251.GA13131@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150623180251.GA13131@redhat.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1465 Lines: 47 On Tue, Jun 23, 2015 at 08:02:51PM +0200, Oleg Nesterov wrote: > vma->vm_ops->mremap() looks more natural and clean in move_vma(), > and this way ->mremap() can have more users. Say, vdso. > > Signed-off-by: Oleg Nesterov > --- > fs/aio.c | 25 ++++++++++++++++--------- > include/linux/fs.h | 1 - > include/linux/mm.h | 1 + > mm/mremap.c | 4 ++-- Please, update Documentation/filesystems/Locking. > 4 files changed, 19 insertions(+), 12 deletions(-) > > diff --git a/fs/aio.c b/fs/aio.c > index 9bc1335..6fe662a 100644 > --- a/fs/aio.c > +++ b/fs/aio.c > @@ -308,15 +308,9 @@ static void aio_free_ring(struct kioctx *ctx) > } > } > > -static int aio_ring_mmap(struct file *file, struct vm_area_struct *vma) > -{ > - vma->vm_flags |= VM_DONTEXPAND; > - vma->vm_ops = &generic_file_vm_ops; > - return 0; > -} > - > -static int aio_ring_remap(struct file *file, struct vm_area_struct *vma) > +static int aio_ring_remap(struct vm_area_struct *vma) I guess aio_ring_mremap() would be a better name. > { > + struct file *file = vma->vm_file; > struct mm_struct *mm = vma->vm_mm; > struct kioctx_table *table; > int i, res = -EINVAL; -- Kirill A. Shutemov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/