Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933372AbbFWS0u (ORCPT ); Tue, 23 Jun 2015 14:26:50 -0400 Received: from mail-pa0-f47.google.com ([209.85.220.47]:32971 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933113AbbFWS0n (ORCPT ); Tue, 23 Jun 2015 14:26:43 -0400 Date: Tue, 23 Jun 2015 11:26:33 -0700 From: Brian Norris To: Michal Suchanek Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Kukjin Kim , Krzysztof Kozlowski , Vinod Koul , Dan Williams , David Woodhouse , Han Xu , Mark Brown , Geert Uytterhoeven , Marek Vasut , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Alison Chaiken , Huang Shijie , Ben Hutchings , Knut Wohlrab , Bean Huo =?utf-8?B?6ZyN5paM5paMIChiZWFuaHVvKQ==?= , "grmoore@altera.com" , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, dmaengine@vger.kernel.org, linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org Subject: Re: [PATCH 04/11] mtd: ofpart: do not fail probe when no partitions exist Message-ID: <20150623182633.GO4917@ld-irv-0074> References: <36e315552c849a4d22ac0fcff7958f6ffcafb160.1433364398.git.hramrach@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <36e315552c849a4d22ac0fcff7958f6ffcafb160.1433364398.git.hramrach@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2349 Lines: 73 On Wed, Jun 03, 2015 at 09:26:40PM -0000, Michal Suchanek wrote: > On Exynos it is necessary to set SPI controller parameters that apply to > a SPI slave in a DT subnode of the slave device. The ofpart code returns > an error when there are subnodes of the SPI flash but no partitions are > found. Change this condition to a warning so that flash without > partitions can be accessed on Exynos. So judging by the subsequent discussion, you're looking at handling nodes like this: flash@... { compatible = "m25p80"; ... controller-data { samsung,spi-feedback-delay = <0>; }; }; Now, I'm not a real fan of this controller-data node in the first place (did that binding get reviewed?). But this is especially bad since we now have collisions on what to do with subnodes that don't have a compatible property. By legacy, ofpart has already claimed ownership of subnodes of an MTD node, where the subnode does not have a compatible property. See Documentation/devicetree/bindings/mtd/partition.txt: "NOTE: if the sub-node has a compatible string, then it is not a partition." So it seems the natural solution is to just define a proper compatibile property for this subnode, and ofpart.c will naturally handle this. See: commit e79265ba6bdb31437bd4c3e7911950f9d1262a07 Author: Josh Wu Date: Mon Aug 5 19:14:38 2013 +0800 mtd: ofpart: add compatible check for child nodes Brian > Signed-off-by: Michal Suchanek > --- > drivers/mtd/ofpart.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mtd/ofpart.c b/drivers/mtd/ofpart.c > index aa26c32..a29d29f 100644 > --- a/drivers/mtd/ofpart.c > +++ b/drivers/mtd/ofpart.c > @@ -94,10 +94,10 @@ static int parse_ofpart_partitions(struct mtd_info *master, > > if (!i) { > of_node_put(pp); > - pr_err("No valid partition found on %s\n", node->full_name); > + pr_warn("No valid partition found on %s\n", node->full_name); > kfree(*pparts); > *pparts = NULL; > - return -EINVAL; > + return 0; > } > > return nr_parts; > -- > 2.1.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/