Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932715AbbFWU7z (ORCPT ); Tue, 23 Jun 2015 16:59:55 -0400 Received: from mail-la0-f41.google.com ([209.85.215.41]:34188 "EHLO mail-la0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754881AbbFWU7t (ORCPT ); Tue, 23 Jun 2015 16:59:49 -0400 MIME-Version: 1.0 In-Reply-To: <20150623180225.GA12882@redhat.com> References: <20150623180225.GA12882@redhat.com> From: Andy Lutomirski Date: Tue, 23 Jun 2015 13:59:27 -0700 Message-ID: Subject: Re: [PATCH 0/1] mm: move ->mremap() from file_operations to vm_operations_struct To: Oleg Nesterov Cc: Andrew Morton , Al Viro , Benjamin LaHaise , Hugh Dickins , Jeff Moyer , Kirill Shutemov , Linus Torvalds , "linux-kernel@vger.kernel.org" , Andy Lutomirski , Pavel Emelyanov Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1253 Lines: 29 On Tue, Jun 23, 2015 at 11:02 AM, Oleg Nesterov wrote: > On 06/22, Andy Lutomirski wrote: >> >> On Mon, Jun 22, 2015 at 5:47 PM, Oleg Nesterov wrote: >> > >> > I never understood why ->mremap() lives in file_operations, not in >> > vm_operations_struct. To me vma->vm_file->f_op in move_vma() just >> > looks strange, vma->vm_ops->mremap(new_vma) looks "obviously better". >> > >> > And afaics more useful. CRIU remaps vdso, but this does not update >> > mm->context.vdso. OK, probably this does not matter currently, CRIU >> > can't c/r the compat tasks, and 64-bit apps do not use context.vdso. >> > Afaics. Still, I think we might want to have special_mapping_remap() >> > and we can't do this because ->vm_file == NULL. >> >> I would like this. Then I could clean up and resubmit my patch to >> keep context.vdso up to date. > > Cough... where can I find this patch ? ;) > https://git.kernel.org/cgit/linux/kernel/git/luto/linux.git/log/?h=vdso/vma_tracking --Andy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/