Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933210AbbFWWq5 (ORCPT ); Tue, 23 Jun 2015 18:46:57 -0400 Received: from gate.crashing.org ([63.228.1.57]:42099 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752275AbbFWWqt (ORCPT ); Tue, 23 Jun 2015 18:46:49 -0400 Message-ID: <1435099588.3996.14.camel@kernel.crashing.org> Subject: Re: [PATCH] PCI: Only enable IO window if supported From: Benjamin Herrenschmidt To: Lorenzo Pieralisi Cc: Bjorn Helgaas , Guenter Roeck , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "suravee.suthikulpanit@amd.com" , Will Deacon Date: Wed, 24 Jun 2015 08:46:28 +1000 In-Reply-To: <20150602145510.GE23650@red-moon> References: <1432342336-25832-1-git-send-email-linux@roeck-us.net> <20150527210447.GY32152@google.com> <20150602145510.GE23650@red-moon> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 642 Lines: 18 On Tue, 2015-06-02 at 15:55 +0100, Lorenzo Pieralisi wrote: > While at it, do you think it is reasonable to also claim the bridge > windows (resources) in the respective pci_read_bridge_* calls ? No, don't claim in read. There's a clear distinction between gathering resources and claiming them, and we need to keep that. Some fixups might happen in between the two for example. Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/