Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933724AbbFWXQE (ORCPT ); Tue, 23 Jun 2015 19:16:04 -0400 Received: from mail-wi0-f179.google.com ([209.85.212.179]:34468 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754944AbbFWXP4 (ORCPT ); Tue, 23 Jun 2015 19:15:56 -0400 Date: Wed, 24 Jun 2015 00:15:52 +0100 From: Luis de Bethencourt To: Dan Carpenter Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, Kirk Reiser , Greg Kroah-Hartman , speakup@linux-speakup.org, Melike Yurtoglu , Domagoj Trsan , Samuel Thibault , Chris Brannon Subject: Re: [PATCH] staging: speakup: replace simple_strtoul() with kstrtoint() Message-ID: <20150623231552.GA19085@turing> References: <20150623204711.GA18380@turing> <20150623225333.GQ28762@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150623225333.GQ28762@mwanda> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 707 Lines: 21 On Wed, Jun 24, 2015 at 01:53:33AM +0300, Dan Carpenter wrote: > Nope. Your patch is totally wrong (buggy). Please be more careful in > the future. > > regards, > dan carpenter > I saw other commits replace the obsolete simple_strtoul() this way and the documentation makes it look like it is a 1 to 1 replacement. Sorry about this. I will investigate further to understand why this is buggy and be more careful in the future. Thanks for the review, Luis -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/