Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933811AbbFXAhK (ORCPT ); Tue, 23 Jun 2015 20:37:10 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:5248 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933726AbbFXAhH (ORCPT ); Tue, 23 Jun 2015 20:37:07 -0400 Message-ID: <5589FBA8.7020204@huawei.com> Date: Wed, 24 Jun 2015 08:36:56 +0800 From: Joseph Qi User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: Nicholas Krause CC: , , Subject: Re: [Ocfs2-devel] [PATCH] ocfs2:Make the function ocfs2_initxattrs static References: <1435103331-16407-1-git-send-email-xerofoify@gmail.com> In-Reply-To: <1435103331-16407-1-git-send-email-xerofoify@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.24.125] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1249 Lines: 39 Hi Nicholas, It has already been staged as a part of the patch "ocfs2: mark local functions as static" in the -mm tree. Thanks all the same. -- Joseph On 2015/6/24 7:48, Nicholas Krause wrote: > This makes the function ocfs2_initxattrs static now due > to this function's only caller being in its own declaration > and definition file of xattr.c. > > Signed-off-by: Nicholas Krause > --- > fs/ocfs2/xattr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ocfs2/xattr.c b/fs/ocfs2/xattr.c > index d03bfbf..889f379 100644 > --- a/fs/ocfs2/xattr.c > +++ b/fs/ocfs2/xattr.c > @@ -7271,7 +7271,7 @@ static int ocfs2_xattr_security_set(struct dentry *dentry, const char *name, > name, value, size, flags); > } > > -int ocfs2_initxattrs(struct inode *inode, const struct xattr *xattr_array, > +static int ocfs2_initxattrs(struct inode *inode, const struct xattr *xattr_array, > void *fs_info) > { > const struct xattr *xattr; > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/