Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934167AbbFXDDx (ORCPT ); Tue, 23 Jun 2015 23:03:53 -0400 Received: from mga14.intel.com ([192.55.52.115]:47446 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934110AbbFXDDg (ORCPT ); Tue, 23 Jun 2015 23:03:36 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,669,1427785200"; d="scan'208";a="716587346" From: Lv Zheng To: "Rafael J. Wysocki" , Len Brown Cc: Lv Zheng , Lv Zheng , , linux-acpi@vger.kernel.org, Bob Moore Subject: [PATCH v2 08/28] ACPICA: Tables: Fix an issue that ACPI initialization is blocked due to no FACS. Date: Wed, 24 Jun 2015 11:03:24 +0800 Message-Id: X-Mailer: git-send-email 1.7.10 In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1722 Lines: 51 ACPICA commit ebd544ed24c5a4faba11f265e228b7a821a729f5 This patch fixes an issue that when FACS tables do not exist, ACPI initialization cannot proceed. ACPICA BZ 1122. Lv Zheng. Link: https://bugs.acpica.org/show_bug.cgi?id=1122 Link: https://github.com/acpica/acpica/commit/ebd544ed Signed-off-by: Lv Zheng Signed-off-by: Bob Moore --- drivers/acpi/acpica/tbutils.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/acpi/acpica/tbutils.c b/drivers/acpi/acpica/tbutils.c index 6a6c5be..2bb6a11 100644 --- a/drivers/acpi/acpica/tbutils.c +++ b/drivers/acpi/acpica/tbutils.c @@ -84,18 +84,16 @@ acpi_status acpi_tb_initialize_facs(void) ACPI_CAST_INDIRECT_PTR(struct acpi_table_header, &acpi_gbl_facs64)); - if (!acpi_gbl_facs32 && !acpi_gbl_facs64) { - return (AE_NO_MEMORY); - } - if (acpi_gbl_use32_bit_facs_addresses) { - acpi_gbl_FACS = - acpi_gbl_facs32 ? acpi_gbl_facs32 : acpi_gbl_facs64; - } else { - acpi_gbl_FACS = - acpi_gbl_facs64 ? acpi_gbl_facs64 : acpi_gbl_facs32; + if (acpi_gbl_facs64 + && (!acpi_gbl_facs32 || !acpi_gbl_use32_bit_facs_addresses)) { + acpi_gbl_FACS = acpi_gbl_facs64; + } else if (acpi_gbl_facs32) { + acpi_gbl_FACS = acpi_gbl_facs32; } + /* If there is no FACS, just continue. There was already an error msg */ + return (AE_OK); } #endif /* !ACPI_REDUCED_HARDWARE */ -- 1.7.10 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/