Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751335AbbFXFV5 (ORCPT ); Wed, 24 Jun 2015 01:21:57 -0400 Received: from mail-pa0-f51.google.com ([209.85.220.51]:33058 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750767AbbFXFVu (ORCPT ); Wed, 24 Jun 2015 01:21:50 -0400 Date: Wed, 24 Jun 2015 10:49:04 +0530 From: maitysanchayan@gmail.com To: Stefan Wahren Cc: srinivas.kandagatla@linaro.org, maxime.ripard@free-electrons.com, linux-arm-kernel@lists.infradead.org, stefan@agner.ch, kernel@pengutronix.de, linux-kernel@vger.kernel.org, shawn.guo@linaro.org, arnd@arndb.de Subject: Re: [RFC PATCH v6 2/2] nvmem: Add Vybrid OCOTP and OCROM support Message-ID: <20150624051903.GA11753@Sanchayan-Arch.toradex.int> References: <1037424954.250728.1435087901102.JavaMail.open-xchange@oxbsltgw00.schlund.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1037424954.250728.1435087901102.JavaMail.open-xchange@oxbsltgw00.schlund.de> User-Agent: Mutt/1.5.23+89 (0255b37be491) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1692 Lines: 48 On 15-06-23 21:31:41, Stefan Wahren wrote: > Hi Sanchayan, > > > Sanchayan Maity hat am 23. Juni 2015 um 15:44 > > geschrieben: > > > > > > The patch adds support for the On Chip One Time Programmable Peripheral > > (OCOTP) and On Chip ROM (OCROM) support. > > > > On Vybrid OCOTP contain data like SoC ID, MAC address and OCROM has the > > revision ID. > > > > Signed-off-by: Sanchayan Maity > > --- > > drivers/nvmem/Kconfig | 11 +++++++++ > > drivers/nvmem/Makefile | 2 ++ > > drivers/nvmem/vf610-ocotp.c | 60 +++++++++++++++++++++++++++++++++++++++++++++ > > 3 files changed, 73 insertions(+) > > create mode 100644 drivers/nvmem/vf610-ocotp.c > > > > diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig > > index 17f1a57..557c1e0 100644 > > --- a/drivers/nvmem/Kconfig > > +++ b/drivers/nvmem/Kconfig > > @@ -33,4 +33,15 @@ config NVMEM_SUNXI_SID > > This driver can also be built as a module. If so, the module > > will be called eeprom-sunxi-sid. > > > > +config NVMEM_VF610_OCOTP > > + tristate "VF610 SoCs OCOTP support" > > + depends on SOC_VF610 > > + select REGMAP_MMIO > > how do you come to the conclusion that Vybrid On-Chip OTP is accessable via > MMIO? Frankly speaking I just changed the naming conventions and followed the qfrom and sunxi sid examples in Srinivas's patches. I just tested it without the "select REGMAP_MMIO" and it works just fine. - Sanchayan. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/