Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1750980AbbFXFhq (ORCPT <rfc822;w@1wt.eu>);
	Wed, 24 Jun 2015 01:37:46 -0400
Received: from mout.web.de ([212.227.17.11]:60407 "EHLO mout.web.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750736AbbFXFhi (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 24 Jun 2015 01:37:38 -0400
Message-ID: <558A4216.8010401@web.de>
Date: Wed, 24 Jun 2015 07:37:26 +0200
From: Jan Kiszka <jan.kiszka@web.de>
User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666
MIME-Version: 1.0
To: Raymond Yau <superquad.vortex2@gmail.com>, alex.hung@canonical.com,
        Hui Wang <hui.wang@canonical.com>,
        Henrique de Moraes Holschuh <hmh@hmh.eng.br>
CC: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        ALSA Development Mailing List <alsa-devel@alsa-project.org>,
        david.henningsson@canonical.com, tiwai@suse.de,
        Hui Wang <jason77.wang@gmail.com>, yk@canonical.com
Subject: Re: [alsa-devel] [V2 PATCH] ALSA: hda - Enable mute/mic-mute LEDs
 for more Thinkpads with Conexant codec
References: <1385534846-20829-1-git-send-email-hui.wang@canonical.com>	<53AFF992.5030403@web.de>	<53B0C596.6090007@canonical.com>	<53B1078B.4090101@web.de>	<53B219DF.6090807@canonical.com>	<53B26575.1000003@web.de>	<53B27ED7.4070401@canonical.com>	<53B50062.30200@web.de>	<53B51B63.8060809@canonical.com>	<53B51CF3.8090102@web.de>	<53B52146.9050300@canonical.com>	<55603F22.8070103@web.de> <CAN8cciZYZ4setSj7dgPqQUVrBrr98tSvofLrD_0zvyQqkWfd2Q@mail.gmail.com> <5560A93E.7060607@web.de>
In-Reply-To: <5560A93E.7060607@web.de>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Provags-ID: V03:K0:2DQeb/atRJqRGG4JVf498webGfIfdLV9PgJ+zBlR2OTovIPKPtC
 ateYjNLPh/TdlbQkC6gXHiselLHmzMlWjH7SktfR99JXrgrK7bx2JZrGgnsxHURlnZfL5fY
 I7hDnPaBn3QwtllO7cTdCYz+Lxu6+vsqfwigEhPXaGqucDuYibuh5C62W7Zedrj2BWnixbb
 zHCNC/avnM3eqe5WePTHA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:MDo15Xk0Of8=:3fBn2LzGGB4/x8z8ILxxEh
 VpI6JxjTWvPwNq8H36dgCXBoiAGGkVavI3ZTjaaeq1M6RpTdwCRg1f4pzSwuwUhrNUvm5hSSQ
 8j7hnAnkxRXjAPLZ7YhULoM1FueV1MrnR7JaPSG9LKvTl+crCqckMM1NzA6dD750tWJ6EYQX6
 My7NkNUWCUik6p2idqlV42tdLC+l5d63BHEadfYgtjMd/2Sjcj4qgs/Xd5Ji5OdZvP9wiyDU/
 X469rfZ5CfZRzRN276+13gS1MK8/BgBbVqpkDKcd8oc3/0KKm0063fIdJET36bmec0jONay95
 KXG+1DwxFPtnpvMLRtsGTPhqNjBXZqwEuMv6N+906gf+fgyAefi5wiQ2dBzaTLc3PTRKV8wSt
 rwh/SneKgk+1tyuPimkJ+kL/Lmzd6oCO7ugThi1rJ59x04UxeXBpmIGNPooML0H20kmn0/DBF
 Bjz8o1gf0hMRYT9p4VOLrAHrzk/V65RIp+sXKORMLwXQZWiNC1Hv3k5i6Hzew6+kvj/hfc476
 dWgyURnl9RBANkwwY6PRpylmPhryZzfHRLwBLkQH/77LisP7uEYMUXFVDQxsCBYCZaviJUYN0
 D94+S6/O81147OuYEsmjjt3zIHfwo8jcMho16Y0QmC22WcCrvNEw61mfC8G3jeiFJ2OH0DmT4
 PVw7Mx93quJNeV/FKID2BgZGaFM7DtYnr/3fUiydXZZ+T3vE/HsbJIEboK2C9Kde71Yg=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 3236
Lines: 91

On 2015-05-23 18:22, Jan Kiszka wrote:
> On 2015-05-23 18:06, Raymond Yau wrote:
>> 2015-5-23 下午4:50 於 "Jan Kiszka" <jan.kiszka@web.de> 寫道：
>>>
>>>>>>>>>>>>>> Most Thinkpad Edge series laptops use conexant codec, so far
>>>>>>>>>>>>>> although
>>>>>>>> <snip>
>>>>>>>>>>> Is there anything I can debug or any information I can collect
>>>>>>>>>>> from my
>>>>>>>>>>> box to examine this?
>>>>>>>>>> What is the linux distribution on your machine? And use showkey to
>>>>>>>>>> catch
>>>>>>>>>> the keycode of that button.
>>>>>>>>> I'm running OpenSUSE 13.1. The reported keycode of the power
>>>>>>>>> button is
>>>>>>>>> 116.
>>>>>>>> It seems the keycode is correct, it is power keycode rather the mute
>>>>>>>> keycode.
>>>>>>>>
>>>>>>>> Could you please do some debug, let us find which line of code is
>> the
>>>>>>>> root cause for this problem. for example:
>>>>>>>>
>>>>>>>> after running the line, the problem shows up:
>>>>>>>>
>>>>>>>> 1.     if (ACPI_SUCCESS(acpi_get_devices("LEN0068", acpi_check_cb,
>>>>>>>> &found, NULL)) && found) // in the sound/pci/hda/thinkpad_helper.c,
>>>>>>>> is_thinkpad()
>>>>>>> This evaluates to true
>>>>>>>
>>>>>>>> 2.     return ACPI_SUCCESS(acpi_get_devices("IBM0068",
>> acpi_check_cb,
>>>>>>>> &found, NULL)) && found; // same as above
>>>>>>>>
>>>>>>>> 3.         if (led_set_func(TPACPI_LED_MUTE, false) >= 0) { //in the
>>>>>>>> sound/pci/hda/thinkpad_helper.c, hda_fixup_thinkpad_acpi()
>>>>>>> ...and this
>>>>>>>
>>>>>>>> 4. if (led_set_func(TPACPI_LED_MICMUTE, false) >= 0) { // same as
>>>>>>>> above
>>>>>>>>
>>>>>>> ...and this as well. spec->num_adc_nids is 1.
>>>>>>
>>>>>> If we change the code like below, does the power button can work well?
>>>>>>
>>>>>> in the thinkpad_helper.c, hda_fixup_thinkpad_acpi()
>>>>>>
>>>>>>
>>>>>>          if (led_set_func(TPACPI_LED_MUTE, false) >= 0) {
>>>>>>              /*
>>>>>>              old_vmaster_hook = spec->vmaster_mute.hook;
>>>>>>              spec->vmaster_mute.hook = update_tpacpi_mute_led;
>>>>>>              removefunc = false;
>>>>>>             */
>>>>> Disabling only this block resolves the issue.
>>>>
>>>> So Below two lines make the power button change to the reset button.
>>>>
>>>> drivers/platform/x86/thinkpad_acpi.c  mute_led_on_off():
>>>>
>>>> acpi_get_handle(hkey_handle, "SSMS", &temp);
>>>> acpi_evalf(hkey_handle, &output, "SSMS", "dd", 1);
>>>>
>>>>
>>>> @alexhung,
>>>> Do you have any idea why this can affect the power button behavior?
>>>>
>>>
>>> I think we all lost track of this issue, but it unfortunately still
>>> exists in the latest kernel, requiring custom builds here. How can we
>>> proceed?
>>
>> http://mailman.alsa-project.org/pipermail/alsa-devel/2015-May/091561.html
>>
>> If you cannot find "SSMS" in  your T520 ACPI dump, this mean mute LED
>> cannot be turn on/off similar to T510
> 
> There is an entry (see attached disassembly), but this device has at
> least no physical LED to drive.
> 
> Jan
> 

Ping...

Jan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/