From: Noam Camus <noamc@ezchip.com>
To: "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC: "vgupta@synopsys.com" <vgupta@synopsys.com>,
        Gilad Ben Yossef <giladb@ezchip.com>,
        Chris Metcalf <cmetcalf@ezchip.com>,
        Andreas Dilger <adilger@dilger.ca>
Subject: Re: [PATCH] fs: heap/bss calculation ignore special section.
Thread-Topic: [PATCH] fs: heap/bss calculation ignore special section.
Thread-Index: AQHQorBXIqdmneoOzEuEhAEQ/vkY7527VuVr
Date: Wed, 24 Jun 2015 07:28:38 +0000
Message-ID: <DB4PR02MB2729B8E783A3B6A4449F06CD6AF0@DB4PR02MB272.eurprd02.prod.outlook.com>
References: <1433853139-28554-1-git-send-email-noamc@ezchip.com>
In-Reply-To: <1433853139-28554-1-git-send-email-noamc@ezchip.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7BIT
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jun 2015 07:28:38.7060
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 0fc16e0a-3cd3-4092-8b2f-0a42cff122c3
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR02MB0431
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1823
Lines: 52

Andreas Dilger suggested that my previous email may be discarded due to my Sender Policy Framework (SPF) .
So I email this from different location, just in case.

Noam
________________________________________
From: Noam Camus
Sent: Tuesday, June 9, 2015 3:32 PM
To: linux-fsdevel@vger.kernel.org; linux-kernel@vger.kernel.org
Cc: vgupta@synopsys.com; Gilad Ben Yossef; Chris Metcalf; Noam Camus
Subject: [PATCH] fs: heap/bss calculation ignore special section.

From: Noam Camus <noamc@ezchip.com>

Today bss/heap is placed above last loaded sections.
However if STACK_TOP is not equal to TASK_SIZE we wish to ignore
such sections mapped to this gap between STACK_TOP and TASK_SIZE.
set_brk will never work for such case.

So at the moment this addition is just a sanity check.

An alternative (more complex):
Linux would make use of LMA field in ELF, then we can set VMA below
STACK_TOP and set LMA to be between STACK_TOP and TASK_SIZE to match
such special memory mapping.

Signed-off-by: Noam Camus <noamc@ezchip.com>
---
 fs/binfmt_elf.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c
index 241ef68..09f9483 100644
--- a/fs/binfmt_elf.c
+++ b/fs/binfmt_elf.c
@@ -962,6 +962,9 @@ static int load_elf_binary(struct linux_binprm *bprm)

                k = elf_ppnt->p_vaddr + elf_ppnt->p_filesz;

+               if (k >= STACK_TOP)
+                       continue;
+
                if (k > elf_bss)
                        elf_bss = k;
                if ((elf_ppnt->p_flags & PF_X) && end_code < k)
--
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/