Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751718AbbFXHyo (ORCPT ); Wed, 24 Jun 2015 03:54:44 -0400 Received: from www.linutronix.de ([62.245.132.108]:43456 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751527AbbFXHy2 (ORCPT ); Wed, 24 Jun 2015 03:54:28 -0400 Date: Wed, 24 Jun 2015 09:53:30 +0200 (CEST) From: Thomas Gleixner To: Paul Osmialowski cc: Andrew Morton , Anson Huang , Ard Biesheuvel , Arnd Bergmann , Bhupesh Sharma , Daniel Lezcano , Frank Li , Geert Uytterhoeven , Greg Kroah-Hartman , Guenter Roeck , Haojian Zhuang , Ian Campbell , Jingchang Lu , Jiri Slaby , Kees Cook , Kumar Gala , Laurent Pinchart , Linus Walleij , Magnus Damm , Michael Turquette , Nathan Lynch , Nicolas Pitre , Maxime Coquelin stm32 , Olof Johansson , Paul Bolle , Rob Herring , Rob Herring , Russell King , Sergey Senozhatsky , Shawn Guo , Simon Horman , Stefan Agner , Stephen Boyd , Uwe Kleine-Koenig , Catalin Marinas , Dave Martin , Mark Rutland , Pawel Moll , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-serial@vger.kernel.org, devicetree@vger.kernel.org, dmaengine@vger.kernel.org, Yuri Tikhonov , Sergei Poselenov , Dmitry Cherkassov , Alexander Potashev Subject: Re: [PATCH 6/9] arm: twr-k70f120m: clock source drivers for Kinetis SoC In-Reply-To: <1435094387-20146-7-git-send-email-pawelo@king.net.pl> Message-ID: References: <1435094387-20146-1-git-send-email-pawelo@king.net.pl> <1435094387-20146-7-git-send-email-pawelo@king.net.pl> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2553 Lines: 84 On Tue, 23 Jun 2015, Paul Osmialowski wrote: > +/* > + * Clock event device set mode function > + */ > +static void kinetis_clockevent_tmr_set_mode( > + enum clock_event_mode mode, struct clock_event_device *clk) > +{ > + struct kinetis_clock_event_ddata *pit = > + container_of(clk, struct kinetis_clock_event_ddata, evtdev); > + > + switch (mode) { > + case CLOCK_EVT_MODE_PERIODIC: > + kinetis_pit_enable(pit->base, 1); > + break; > + case CLOCK_EVT_MODE_ONESHOT: > + case CLOCK_EVT_MODE_UNUSED: > + case CLOCK_EVT_MODE_SHUTDOWN: > + default: > + kinetis_pit_enable(pit->base, 0); > + } > +} Please move to the new set_state_* interfaces. set_mode() is deprecated. > +static int kinetis_clockevent_tmr_set_next_event( > + unsigned long delta, struct clock_event_device *c) > +{ > + struct kinetis_clock_event_ddata *pit = > + container_of(c, struct kinetis_clock_event_ddata, evtdev); > + unsigned long flags; > + > + raw_local_irq_save(flags); Pointless exercise. This is called with interrupts disabled. > + kinetis_pit_init(pit->base, delta); > + kinetis_pit_enable(pit->base, 1); > + raw_local_irq_restore(flags); > +static struct irqaction kinetis_clockevent_irqaction[KINETIS_PIT_CHANNELS] = { > + { > + .name = "Kinetis Kernel Time Tick (pit0)", Please use oneword descriptive names not half sentences. > + .flags = IRQF_TIMER | IRQF_IRQPOLL, > + .dev_id = &kinetis_clockevent_tmrs[0], > + .handler = kinetis_clockevent_tmr_irq_handler, > + }, { > + .name = "Kinetis Kernel Time Tick (pit1)", > + .flags = IRQF_TIMER | IRQF_IRQPOLL, > + .dev_id = &kinetis_clockevent_tmrs[1], > + .handler = kinetis_clockevent_tmr_irq_handler, > + }, { > + .name = "Kinetis Kernel Time Tick (pit2)", > + .flags = IRQF_TIMER | IRQF_IRQPOLL, > + .dev_id = &kinetis_clockevent_tmrs[2], > + .handler = kinetis_clockevent_tmr_irq_handler, > + }, { > + .name = "Kinetis Kernel Time Tick (pit3)", > + .flags = IRQF_TIMER | IRQF_IRQPOLL, > + .dev_id = &kinetis_clockevent_tmrs[3], > + .handler = kinetis_clockevent_tmr_irq_handler, > + }, Aside of that. Please use standard request_irq() there is no reason to use setup_irq here. > + > + setup_irq(irq, &(kinetis_clockevent_irqaction[chan])); request_irq(irq, handler, flags, "name", &kinetis_clockevent_tmrs[chan]); .... Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/