Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751689AbbFXIRW (ORCPT <rfc822;w@1wt.eu>);
	Wed, 24 Jun 2015 04:17:22 -0400
Received: from mail-wi0-f173.google.com ([209.85.212.173]:37133 "EHLO
	mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751061AbbFXIRL (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 24 Jun 2015 04:17:11 -0400
Message-ID: <1435133827.2334.33.camel@linaro.org>
Subject: Re: [PATCH 5/8] pinctrl: qcom: spmi-mpp: Add support for setting
 analog output level
From: "Ivan T. Ivanov" <ivan.ivanov@linaro.org>
To: Bjorn Andersson <bjorn.andersson@sonymobile.com>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        Linus Walleij <linus.walleij@linaro.org>, devicetree@vger.kernel.org,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-msm@vger.kernel.org
Date: Wed, 24 Jun 2015 11:17:07 +0300
In-Reply-To: <1434610052-602-6-git-send-email-bjorn.andersson@sonymobile.com>
References: <1434610052-602-1-git-send-email-bjorn.andersson@sonymobile.com>
	 <1434610052-602-6-git-send-email-bjorn.andersson@sonymobile.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.13.7-fta1.2~trusty 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 914
Lines: 34

Hi Bjorn, 

On Wed, 2015-06-17 at 23:47 -0700, Bjorn Andersson wrote:
> When the MPP is configured for analog output the output level is selected by
> the AOUT_CTL register, this patch makes it possible to control this.
> 
<snip>

>         }
> @@ -748,6 +765,10 @@ static int pmic_mpp_populate(struct pmic_mpp_state *state,
> 
>         pad->drive_strength = val;
> 
> +       val = pmic_mpp_read(state, pad, PMIC_MPP_REG_AOUT_CTL);
> +       if (val < 0)
> +               return val;
> +

Missing 

        pad->aout_level = val;

>         val = pmic_mpp_read(state, pad, PMIC_MPP_REG_EN_CTL);
>         if (val < 0)
>                 return val;
> 

Regards,
Ivan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/