Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751469AbbFXIkK (ORCPT ); Wed, 24 Jun 2015 04:40:10 -0400 Received: from down.free-electrons.com ([37.187.137.238]:49780 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751098AbbFXIkD (ORCPT ); Wed, 24 Jun 2015 04:40:03 -0400 Date: Wed, 24 Jun 2015 10:35:29 +0200 From: Maxime Ripard To: srinivas.kandagatla@linaro.org, Sanchayan Maity Cc: linux-arm-kernel@lists.infradead.org, arnd@arndb.de, linux-kernel@vger.kernel.org, stefan@agner.ch, kernel@pengutronix.de, shawn.guo@linaro.org Subject: Re: [RFC PATCH v6 2/2] nvmem: Add Vybrid OCOTP and OCROM support Message-ID: <20150624083529.GY2266@lukather> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="JVTyp1F/hrbhzAAs" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1936 Lines: 58 --JVTyp1F/hrbhzAAs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi,=20 On Tue, Jun 23, 2015 at 07:14:57PM +0530, Sanchayan Maity wrote: > +static struct nvmem_config ocotp_config =3D { > + .name =3D "soc_id", > +}; > + > +static struct nvmem_config rom_config =3D { > + .name =3D "rom_rev", > +}; Srinivas, shouldn't we use the DT to setup these names, just like clock-output-names does for example? This is very likely to change from one board to another, and defining a new compatible and/or driver for each board seems a bit fishy. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --JVTyp1F/hrbhzAAs Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVimvRAAoJEBx+YmzsjxAgSNEP/1RXczMrqWD0iDLy/QIW3qMS 0MCYM8Y61puFVhbXANuls0NRxujKTesMiRkJ5AQGzGQVuB6tJqv6jPQBmXUHPueU eH+JzOuFNYKwkAxyQHDRrVdn5fR0ShRlOpo0Cg9GkoARz/6/kdXN/cadq5yvdeY8 rzh2Pica2IWJ/N5eiHwmUzJB7MaxiSM3bFN6U2PEJQTkoA9uL1dRbatAORFJHbX6 e9tOZZ0pWlpQkdh/cKNmYjcMGVj4pwjZ0nkzcc64+pwU6ULqeL9DBk9/B+jxnzPY aH1GR5q7C9Lpp5uEWdhd9ho+EQVhvuoL5mPImI7TNlZT6rHJRnnulyKt7CnPfpar pbEr+PfSs4eVpU6qrr9kkpEToe6RDwPsOdlZd86cDcr9orvKErAkSiJx48eMytou mCjHbNq/G6ZDa67UzIDsMP+Zk/WJe5RENR0P5CNcBSpKCKU3BiXSMd0qUYGx7gak I3CXPF2sWNcie0KQ4bETsVlJ1/Pq7bN+1/UgFCzKl3UVoRdGfdvfARCs9TEniUvH zilz0YXeQcH7L59vXtwZM0X3lZ+wFrwgdir9uLWjXzJ2riy1Gyg8cBaAqjO0RMP3 B8X0vdOCq4kMpH6IRQs2uA1BA4zFXGPXYUh4o9h7G49kLvtwed2XRJdqCpw03G2Y zmvT7TAlnh1IxWHcERTO =4Hsr -----END PGP SIGNATURE----- --JVTyp1F/hrbhzAAs-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/