Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751925AbbFXIrU (ORCPT <rfc822;w@1wt.eu>);
	Wed, 24 Jun 2015 04:47:20 -0400
Received: from youngberry.canonical.com ([91.189.89.112]:55197 "EHLO
	youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751463AbbFXIrG (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 24 Jun 2015 04:47:06 -0400
Message-ID: <558A6E80.7010003@canonical.com>
Date: Wed, 24 Jun 2015 16:46:56 +0800
From: Hui Wang <hui.wang@canonical.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: Jan Kiszka <jan.kiszka@web.de>, Raymond Yau <superquad.vortex2@gmail.com>,
        alex.hung@canonical.com, Henrique de Moraes Holschuh <hmh@hmh.eng.br>
CC: ALSA Development Mailing List <alsa-devel@alsa-project.org>,
        Hui Wang <jason77.wang@gmail.com>, tiwai@suse.de,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        yk@canonical.com, david.henningsson@canonical.com
Subject: Re: [alsa-devel] [V2 PATCH] ALSA: hda - Enable mute/mic-mute LEDs
 for more Thinkpads with Conexant codec
References: <1385534846-20829-1-git-send-email-hui.wang@canonical.com>	<53AFF992.5030403@web.de>	<53B0C596.6090007@canonical.com>	<53B1078B.4090101@web.de>	<53B219DF.6090807@canonical.com>	<53B26575.1000003@web.de>	<53B27ED7.4070401@canonical.com>	<53B50062.30200@web.de>	<53B51B63.8060809@canonical.com>	<53B51CF3.8090102@web.de>	<53B52146.9050300@canonical.com>	<55603F22.8070103@web.de> <CAN8cciZYZ4setSj7dgPqQUVrBrr98tSvofLrD_0zvyQqkWfd2Q@mail.gmail.com> <5560A93E.7060607@web.de> <558A4216.8010401@web.de>
In-Reply-To: <558A4216.8010401@web.de>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 3669
Lines: 94

On 06/24/2015 01:37 PM, Jan Kiszka wrote:
> On 2015-05-23 18:22, Jan Kiszka wrote:
>> On 2015-05-23 18:06, Raymond Yau wrote:
>>> 2015-5-23 下午4:50 於 "Jan Kiszka" <jan.kiszka@web.de> 寫道：
>>>>>>>>>>>>>>> Most Thinkpad Edge series laptops use conexant codec, so far
>>>>>>>>>>>>>>> although
>>>>>>>>> <snip>
>>>>>>>>>>>> Is there anything I can debug or any information I can collect
>>>>>>>>>>>> from my
>>>>>>>>>>>> box to examine this?
>>>>>>>>>>> What is the linux distribution on your machine? And use showkey to
>>>>>>>>>>> catch
>>>>>>>>>>> the keycode of that button.
>>>>>>>>>> I'm running OpenSUSE 13.1. The reported keycode of the power
>>>>>>>>>> button is
>>>>>>>>>> 116.
>>>>>>>>> It seems the keycode is correct, it is power keycode rather the mute
>>>>>>>>> keycode.
>>>>>>>>>
>>>>>>>>> Could you please do some debug, let us find which line of code is
>>> the
>>>>>>>>> root cause for this problem. for example:
>>>>>>>>>
>>>>>>>>> after running the line, the problem shows up:
>>>>>>>>>
>>>>>>>>> 1.     if (ACPI_SUCCESS(acpi_get_devices("LEN0068", acpi_check_cb,
>>>>>>>>> &found, NULL)) && found) // in the sound/pci/hda/thinkpad_helper.c,
>>>>>>>>> is_thinkpad()
>>>>>>>> This evaluates to true
>>>>>>>>
>>>>>>>>> 2.     return ACPI_SUCCESS(acpi_get_devices("IBM0068",
>>> acpi_check_cb,
>>>>>>>>> &found, NULL)) && found; // same as above
>>>>>>>>>
>>>>>>>>> 3.         if (led_set_func(TPACPI_LED_MUTE, false) >= 0) { //in the
>>>>>>>>> sound/pci/hda/thinkpad_helper.c, hda_fixup_thinkpad_acpi()
>>>>>>>> ...and this
>>>>>>>>
>>>>>>>>> 4. if (led_set_func(TPACPI_LED_MICMUTE, false) >= 0) { // same as
>>>>>>>>> above
>>>>>>>>>
>>>>>>>> ...and this as well. spec->num_adc_nids is 1.
>>>>>>> If we change the code like below, does the power button can work well?
>>>>>>>
>>>>>>> in the thinkpad_helper.c, hda_fixup_thinkpad_acpi()
>>>>>>>
>>>>>>>
>>>>>>>           if (led_set_func(TPACPI_LED_MUTE, false) >= 0) {
>>>>>>>               /*
>>>>>>>               old_vmaster_hook = spec->vmaster_mute.hook;
>>>>>>>               spec->vmaster_mute.hook = update_tpacpi_mute_led;
>>>>>>>               removefunc = false;
>>>>>>>              */
>>>>>> Disabling only this block resolves the issue.
>>>>> So Below two lines make the power button change to the reset button.
>>>>>
>>>>> drivers/platform/x86/thinkpad_acpi.c  mute_led_on_off():
>>>>>
>>>>> acpi_get_handle(hkey_handle, "SSMS", &temp);
>>>>> acpi_evalf(hkey_handle, &output, "SSMS", "dd", 1);
>>>>>
>>>>>
>>>>> @alexhung,
>>>>> Do you have any idea why this can affect the power button behavior?
>>>>>
>>>> I think we all lost track of this issue, but it unfortunately still
>>>> exists in the latest kernel, requiring custom builds here. How can we
>>>> proceed?
>>> http://mailman.alsa-project.org/pipermail/alsa-devel/2015-May/091561.html
>>>
>>> If you cannot find "SSMS" in  your T520 ACPI dump, this mean mute LED
>>> cannot be turn on/off similar to T510
>> There is an entry (see attached disassembly), but this device has at
>> least no physical LED to drive.
Some hotkey leds are embedded on button.  Through the pictures I found 
on the internet (thinkpad t520), it looks like there is a led at the 
center of the mute button.


Jan

> Ping...
>
> Jan
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/