Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752376AbbFXJ3E (ORCPT ); Wed, 24 Jun 2015 05:29:04 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:48496 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751374AbbFXJ2y (ORCPT ); Wed, 24 Jun 2015 05:28:54 -0400 Date: Wed, 24 Jun 2015 12:28:41 +0300 From: Dan Carpenter To: Juston Li Cc: Sudip Mukherjee , teddy.wang@siliconmotion.com, Greg KH , linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: sm750fb: use tabs for indentation Message-ID: <20150624092841.GJ30834@mwanda> References: <1434761450-15722-1-git-send-email-juston.h.li@gmail.com> <20150622174601.GF28762@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1214 Lines: 35 On Mon, Jun 22, 2015 at 11:30:30AM -0700, Juston Li wrote: > On Mon, Jun 22, 2015 at 10:46 AM, Dan Carpenter > wrote: > > On Fri, Jun 19, 2015 at 05:50:50PM -0700, Juston Li wrote: > >> void sii164ClearInterrupt(void) > >> { > >> - unsigned char detectReg; > >> + unsigned char detectReg; > >> > >> - /* Clear the MDI interrupt */ > >> - detectReg = i2cReadReg(SII164_I2C_ADDRESS, SII164_DETECT); > >> - i2cWriteReg(SII164_I2C_ADDRESS, SII164_DETECT, detectReg | SII164_DETECT_MONITOR_STATE_CLEAR); > > > > The patch accidentally deletes this write. > > > >> + /* Clear the MDI interrupt */ > >> + detectReg = i2cReadReg(SII164_I2C_ADDRESS, SII164_DETECT); > >> } > > > > regards, > > dan carpenter > > This was fixed and patch is now included in the patchset: > [PATCH v2 00/19] staging: sm750fb: checkpatch.pl fixes Have you sent this patchset to the list? I don't see it in my inbox. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/