Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752036AbbFXJe4 (ORCPT ); Wed, 24 Jun 2015 05:34:56 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:35028 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750937AbbFXJes (ORCPT ); Wed, 24 Jun 2015 05:34:48 -0400 Message-ID: <558A79B3.1010205@linaro.org> Date: Wed, 24 Jun 2015 10:34:43 +0100 From: Srinivas Kandagatla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Maxime Ripard , Sanchayan Maity CC: linux-arm-kernel@lists.infradead.org, arnd@arndb.de, linux-kernel@vger.kernel.org, stefan@agner.ch, kernel@pengutronix.de, shawn.guo@linaro.org Subject: Re: [RFC PATCH v6 2/2] nvmem: Add Vybrid OCOTP and OCROM support References: <20150624083529.GY2266@lukather> In-Reply-To: <20150624083529.GY2266@lukather> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1219 Lines: 41 On 24/06/15 09:35, Maxime Ripard wrote: > Hi, > > On Tue, Jun 23, 2015 at 07:14:57PM +0530, Sanchayan Maity wrote: >> +static struct nvmem_config ocotp_config = { >> + .name = "soc_id", >> +}; >> + >> +static struct nvmem_config rom_config = { >> + .name = "rom_rev", >> +}; > > Srinivas, shouldn't we use the DT to setup these names, just like > clock-output-names does for example? These are the provider names, which would not change per board, I think. :-) On the other hand if we are going to use generic drivers like "simple-mmio-nvmem" then having name DT bindings makes sense. IMO, clock-output-names are analogous to nvmem consumers, which are obviously getting there names from cell node name ATM. > > This is very likely to change from one board to another, and defining > a new compatible and/or driver for each board seems a bit fishy. > Do you have any particular example in mind, where the provider names would change per board? --srini > Maxime > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/