Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752219AbbFXJr1 (ORCPT ); Wed, 24 Jun 2015 05:47:27 -0400 Received: from mail-pd0-f181.google.com ([209.85.192.181]:34941 "EHLO mail-pd0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752161AbbFXJrQ (ORCPT ); Wed, 24 Jun 2015 05:47:16 -0400 Date: Wed, 24 Jun 2015 15:14:32 +0530 From: Sanchayan Maity To: Srinivas Kandagatla Cc: Stefan Wahren , maxime.ripard@free-electrons.com, linux-arm-kernel@lists.infradead.org, stefan@agner.ch, kernel@pengutronix.de, linux-kernel@vger.kernel.org, shawn.guo@linaro.org, arnd@arndb.de Subject: Re: [RFC PATCH v6 2/2] nvmem: Add Vybrid OCOTP and OCROM support Message-ID: <20150624094432.GD11753@Sanchayan-Arch.toradex.int> References: <1037424954.250728.1435087901102.JavaMail.open-xchange@oxbsltgw00.schlund.de> <20150624051903.GA11753@Sanchayan-Arch.toradex.int> <558A7A67.806@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <558A7A67.806@linaro.org> User-Agent: Mutt/1.5.23+89 (0255b37be491) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 881 Lines: 23 On 15-06-24 10:37:43, Srinivas Kandagatla wrote: > > > On 24/06/15 06:19, maitysanchayan@gmail.com wrote: > >I just tested it without the "select REGMAP_MMIO" and it works just fine. > You just got lucky in this case, as REGMAP_MMIO is getting selected > somewhere else. > > Drivers should directly select the dependecies. In this case this driver > actually is going to use REGMAP_MMIO, so keeping it selected is the right > thing. Yes, you are right. Checking the .config file shows that this is enabled even with the explicit selection removed in my driver's kconfig. Sorry about missing that Stefan and Srinivas. - Sanchayan. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/