Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752433AbbFXJtE (ORCPT ); Wed, 24 Jun 2015 05:49:04 -0400 Received: from mail-wi0-f179.google.com ([209.85.212.179]:34291 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752350AbbFXJtA (ORCPT ); Wed, 24 Jun 2015 05:49:00 -0400 Message-ID: <558A7D08.1000403@linaro.org> Date: Wed, 24 Jun 2015 10:48:56 +0100 From: Srinivas Kandagatla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Stefan Wahren , Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org CC: wxt@rock-chips.com, linux-api@vger.kernel.org, Kumar Gala , Rob Herring , sboyd@codeaurora.org, arnd@arndb.de, s.hauer@pengutronix.de, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, mporter@konsulko.com, Maxime Ripard , pantelis.antoniou@konsulko.com, devicetree@vger.kernel.org, Mark Brown Subject: Re: [PATCH v6 8/9] nvmem: sunxi: Move the SID driver to the nvmem framework References: <1435014459-26138-1-git-send-email-srinivas.kandagatla@linaro.org> <1435014583-26478-1-git-send-email-srinivas.kandagatla@linaro.org> <1335062615.252618.1435092272970.JavaMail.open-xchange@oxbsltgw00.schlund.de> In-Reply-To: <1335062615.252618.1435092272970.JavaMail.open-xchange@oxbsltgw00.schlund.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1364 Lines: 46 On 23/06/15 21:44, Stefan Wahren wrote: > >> Srinivas Kandagatla hat am 23. Juni 2015 um >> 01:09 geschrieben: >> >> >> From: Maxime Ripard >> >> Now that we have the nvmem framework, we can consolidate the common >> driver code. Move the driver to the framework, and hopefully, it will >> fix the sysfs file creation race. >> --- /dev/null >> +++ b/drivers/nvmem/sunxi-sid.c >> [...] >> + >> +static int sunxi_sid_write(void *context, const void *data, size_t count) >> +{ >> + /* Unimplemented */ >> + return 0; >> +} >> + > > I think it should be clear that the write operation isn't implemented. It's more > important to know the function should make > regmap_init happy. I totally agree with you.. It was just to make regmap_init happy. Indeed I thought of adding this comment, but forgot over the time :-) I will fix it. --srini > -- > To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/