Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752529AbbFXJww (ORCPT ); Wed, 24 Jun 2015 05:52:52 -0400 Received: from mail-wg0-f44.google.com ([74.125.82.44]:34494 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752127AbbFXJwn (ORCPT ); Wed, 24 Jun 2015 05:52:43 -0400 Message-ID: <558A7DE6.9060000@linaro.org> Date: Wed, 24 Jun 2015 10:52:38 +0100 From: Srinivas Kandagatla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Stefan Wahren , Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org CC: wxt@rock-chips.com, linux-api@vger.kernel.org, Kumar Gala , Rob Herring , sboyd@codeaurora.org, arnd@arndb.de, s.hauer@pengutronix.de, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, mporter@konsulko.com, Maxime Ripard , pantelis.antoniou@konsulko.com, devicetree@vger.kernel.org, Mark Brown Subject: Re: [PATCH v6 3/9] nvmem: Add nvmem_device based consumer apis. References: <1435014459-26138-1-git-send-email-srinivas.kandagatla@linaro.org> <1435014527-26265-1-git-send-email-srinivas.kandagatla@linaro.org> <1344600420.252283.1435091331020.JavaMail.open-xchange@oxbsltgw00.schlund.de> In-Reply-To: <1344600420.252283.1435091331020.JavaMail.open-xchange@oxbsltgw00.schlund.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1375 Lines: 32 On 23/06/15 21:28, Stefan Wahren wrote: >> >@@ -26,6 +35,21 @@ void devm_nvmem_cell_put(struct device *dev, struct >> >nvmem_cell *cell); >> >void *nvmem_cell_read(struct nvmem_cell *cell, ssize_t *len); >> >int nvmem_cell_write(struct nvmem_cell *cell, void *buf, ssize_t len); >> > >> >+/* direct nvmem device read/write interface */ >> >+struct nvmem_device *nvmem_device_get(struct device *dev, const char *name); >> >+struct nvmem_device *devm_nvmem_device_get(struct device *dev, >> >+ const char *name); >> >+void nvmem_device_put(struct nvmem_device *nvmem); >> >+void devm_nvmem_device_put(struct device *dev, struct nvmem_device *nvmem); >> >+int nvmem_device_read(struct nvmem_device *nvmem, unsigned int offset, >> >+ size_t bytes, void *buf); >> >+int nvmem_device_write(struct nvmem_device *nvmem, unsigned int offset, >> >+ size_t bytes, void *buf); > Maybe i mixed something but those functions use the datatype unsigned int for > offset > and the offset in the structs use datatype int. Looks a little bit inconsistent. thanks for comments, I will have a relook at this and see if I can fix it. thanks, srini -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/