Date: Wed, 24 Jun 2015 12:19:27 +0200
From: Luis de Bethencourt <luis@debethencourt.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>, devel@driverdev.osuosl.org,
        Kirk Reiser <kirk@reisers.ca>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        speakup@linux-speakup.org,
        Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
        linux-kernel@vger.kernel.org, Domagoj Trsan <domagoj.trsan@gmail.com>,
        Samuel Thibault <samuel.thibault@ens-lyon.org>,
        Chris Brannon <chris@the-brannons.com>
Subject: Re: [PATCH] staging: speakup: replace simple_strtoul() with
 kstrtoint()
Message-ID: <20150624101927.GB30628@goodgumbo.baconseed.org>
References: <20150623204711.GA18380@turing>
 <20150623225333.GQ28762@mwanda>
 <20150623231552.GA19085@turing>
 <20150624052330.GA3881@sudip-PC>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150624052330.GA3881@sudip-PC>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1428
Lines: 39

On Wed, Jun 24, 2015 at 10:53:30AM +0530, Sudip Mukherjee wrote:
> On Wed, Jun 24, 2015 at 12:15:52AM +0100, Luis de Bethencourt wrote:
> > On Wed, Jun 24, 2015 at 01:53:33AM +0300, Dan Carpenter wrote:
> > > Nope.  Your patch is totally wrong (buggy).  Please be more careful in
> > > the future.
> > > 
> > > regards,
> > > dan carpenter
> > > 
> > 
> > I saw other commits replace the obsolete simple_strtoul() this way and the
> > documentation makes it look like it is a 1 to 1 replacement.
> > 
> > Sorry about this. I will investigate further to understand why this is buggy
> > and be more careful in the future.
> simple_strtoul returns unsigned long and kstrtoint gives int.
> documentation says to use kstrtoul.
> 
> regards
> sudip

Hello again Sudip :)

simple_strtoul returns an unsigned long, but in this case this is downcasted to
int val. If we use kstrtoul there would be a type warning since the function
expects the reference to an unsigned long. Which is why I used the related
kstrtoint.

Dan has said this is buggy. I have an idea why this might be. I am isolating
the code and playing with it before submitting a second version.

Thanks for the review.

Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/