Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752703AbbFXL3o (ORCPT ); Wed, 24 Jun 2015 07:29:44 -0400 Received: from mga14.intel.com ([192.55.52.115]:34027 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751805AbbFXL3f (ORCPT ); Wed, 24 Jun 2015 07:29:35 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,671,1427785200"; d="scan'208";a="513475145" Date: Wed, 24 Jun 2015 14:27:23 +0300 From: Mika Westerberg To: christian.ruppert@alitech.com Cc: Lucas De Marchi , Christian Ruppert , Fabio Mello , Jarkko Nikula , linux-i2c@vger.kernel.org, lkml , Lucas De Marchi , Wolfram Sang Subject: Re: [PATCH] i2c: designware: use enable on resume instead initialization Message-ID: <20150624112723.GE827@lahna.fi.intel.com> References: <1433785828-4100-1-git-send-email-lucas.de.marchi@gmail.com> <20150609085146.GD1478@lahna.fi.intel.com> <20150610070722.GM1478@lahna.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1435 Lines: 34 On Wed, Jun 24, 2015 at 09:36:43AM +0200, christian.ruppert@alitech.com wrote: > Dear Lucas, > > Lucas De Marchi wrote on 23.06.2015 19:02:03: > > On Tue, Jun 23, 2015 at 1:45 PM, wrote: > > > Hello, > > > > > > Christian Ruppert/ALi_GVA/ALi wrote on 10.06.2015 17:05:16: > > [...] > > > The result is not very encouraging: Out of five (identical) designware > i2c > > > controllers we have on my test SOC, the first one initialises properly > but > > > the second one gets stuck in the famous irq loop right away when the > > > module is enabled in i2c_dw_init. The system never gets around to try > > > > Are you using the pci or platform driver? I noticed yesterday the pci > > version is failing here with a NULL pointer dereference. > > The test was performed with the platform driver (instantiated through > device tree). > I just re-checked and the ultimate problem which hangs/kills the system in > my case is the IRQ loop. > I haven't observed any NULL pointer dereferences on the road. Thanks Christian for testing. Since the patch causes problems on your hardware, I don't think it is good idea to merge it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/