Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932165AbbFXMpR (ORCPT ); Wed, 24 Jun 2015 08:45:17 -0400 Received: from mail-lb0-f170.google.com ([209.85.217.170]:33207 "EHLO mail-lb0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753371AbbFXMor (ORCPT ); Wed, 24 Jun 2015 08:44:47 -0400 MIME-Version: 1.0 In-Reply-To: <558AA52B.1030809@users.sourceforge.net> References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <558AA52B.1030809@users.sourceforge.net> Date: Wed, 24 Jun 2015 14:44:45 +0200 Message-ID: Subject: Re: [PATCH] kdbus: Delete an unnecessary check before the function call "kdbus_domain_unref" From: David Herrmann To: SF Markus Elfring Cc: Daniel Mack , David Herrmann , Djalal Harouni , Greg Kroah-Hartman , LKML , "kernel-janitors@vger.kernel.org" , Julia Lawall Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1516 Lines: 51 Hi On Wed, Jun 24, 2015 at 2:40 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 24 Jun 2015 14:30:17 +0200 > > The kdbus_domain_unref() function tests whether its argument is NULL > and then returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > ipc/kdbus/fs.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/ipc/kdbus/fs.c b/ipc/kdbus/fs.c > index d01f33b..205a3ad 100644 > --- a/ipc/kdbus/fs.c > +++ b/ipc/kdbus/fs.c > @@ -325,9 +325,7 @@ static void fs_super_kill(struct super_block *sb) > } > > kill_anon_super(sb); > - > - if (domain) > - kdbus_domain_unref(domain); > + kdbus_domain_unref(domain); Yeah, your patch is correct. The condition was kinda nice as it shows the connection to the tear-down before the call to kill_anon_super(). But the function is simple enough for a reader to figure out themselves. Reviewed-by: David Herrmann Thanks David > } > > static int fs_super_set(struct super_block *sb, void *data) > -- > 2.4.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/