Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753075AbbFXMtk (ORCPT ); Wed, 24 Jun 2015 08:49:40 -0400 Received: from mail-wg0-f47.google.com ([74.125.82.47]:33611 "EHLO mail-wg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751552AbbFXMte (ORCPT ); Wed, 24 Jun 2015 08:49:34 -0400 Date: Wed, 24 Jun 2015 14:49:28 +0200 From: Ingo Molnar To: Srikar Dronamraju Cc: Arnaldo Carvalho de Melo , Jiri Olsa , Vinson Lee , Ingo Molnar , LKML , Namhyung Kim , Masami Hiramatsu Subject: Re: Regression in perf bench numa convergence stats Message-ID: <20150624124928.GA3921@gmail.com> References: <20150624111004.GA5220@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150624111004.GA5220@linux.vnet.ibm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1815 Lines: 55 * Srikar Dronamraju wrote: > perf bench numa mem with -c / -m options on v4.1 and latest tip arent > showing correct convergence statistics. I ran git bisect between v4.0 and > v4.1. I have included the patch that fixed the problem for me. > From 88199ad8a3d6495080eaa016b87a612bc742b1c4 Mon Sep 17 00:00:00 2001 > From: Srikar Dronamraju > Date: Wed, 24 Jun 2015 16:23:22 +0530 > Subject: [PATCH] perf tools:Fix perf_bench to show proper convergence > > With commit: e1e455f (perf tools: Work around lack of sched_getcpu in > glibc < 2.6), perf_bench numa mem with -c or -m option is not able to > correctly calculate convergence. With the above commit, sched_getcpu > always seems to return -1. The intention of commit e1e455f was to add a > sched_getcpu in glibc < 2.6. Hence keep the sched_getcpu definition > under an ifdef. > > This regression happened occurred between v4.0 and v4.1 > > Signed-off-by: Srikar Dronamraju > --- > tools/perf/util/cloexec.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/tools/perf/util/cloexec.c b/tools/perf/util/cloexec.c > index 85b5238..2babdda 100644 > --- a/tools/perf/util/cloexec.c > +++ b/tools/perf/util/cloexec.c > @@ -7,11 +7,15 @@ > > static unsigned long flag = PERF_FLAG_FD_CLOEXEC; > > +#ifdef __GLIBC_PREREQ > +#if !__GLIBC_PREREQ(2, 6) > int __weak sched_getcpu(void) > { > errno = ENOSYS; > return -1; > } > +#endif > +#endif > Thanks Srikar! Acked-by: Ingo Molnar Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/