Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752940AbbFXM4l (ORCPT ); Wed, 24 Jun 2015 08:56:41 -0400 Received: from mga09.intel.com ([134.134.136.24]:44687 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752756AbbFXM41 (ORCPT ); Wed, 24 Jun 2015 08:56:27 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,671,1427785200"; d="scan'208";a="513508441" From: "De Marchi, Lucas" To: "mika.westerberg@linux.intel.com" , "christian.ruppert@alitech.com" CC: "lucas.de.marchi@gmail.com" , "linux-kernel@vger.kernel.org" , "wsa@the-dreams.de" , "Mello, Fabio" , "jarkko.nikula@linux.intel.com" , "christian.ruppert@abilis.com" , "linux-i2c@vger.kernel.org" Subject: Re: [PATCH] i2c: designware: use enable on resume instead initialization Thread-Topic: [PATCH] i2c: designware: use enable on resume instead initialization Thread-Index: AQHQohQERxwB9CtwO0+ilrKbreVIMJ2kVDgAgAChSICAANPhAIAUmetPgAB6i4CAAPRhgIAAQHOAgAAY2AA= Date: Wed, 24 Jun 2015 12:56:19 +0000 Message-ID: <1435150578.1075.5.camel@intel.com> References: <1433785828-4100-1-git-send-email-lucas.de.marchi@gmail.com> <20150609085146.GD1478@lahna.fi.intel.com> <20150610070722.GM1478@lahna.fi.intel.com> <20150624112723.GE827@lahna.fi.intel.com> In-Reply-To: <20150624112723.GE827@lahna.fi.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.76.209] Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id t5OCukBb017166 Content-Length: 1982 Lines: 48 On Wed, 2015-06-24 at 14:27 +0300, Mika Westerberg wrote: > On Wed, Jun 24, 2015 at 09:36:43AM +0200, christian.ruppert@alitech.com wrot > e: > > Dear Lucas, > > > > Lucas De Marchi wrote on 23.06.2015 19:02:03: > > > On Tue, Jun 23, 2015 at 1:45 PM, wrote: > > > > Hello, > > > > > > > > Christian Ruppert/ALi_GVA/ALi wrote on 10.06.2015 17:05:16: > > > [...] > > > > The result is not very encouraging: Out of five (identical) designware > > > > > > i2c > > > > controllers we have on my test SOC, the first one initialises properly > > > > > > but > > > > the second one gets stuck in the famous irq loop right away when the > > > > module is enabled in i2c_dw_init. The system never gets around to try > > > > > > Are you using the pci or platform driver? I noticed yesterday the pci > > > version is failing here with a NULL pointer dereference. > > > > The test was performed with the platform driver (instantiated through > > device tree). > > I just re-checked and the ultimate problem which hangs/kills the system in > > > > my case is the IRQ loop. > > I haven't observed any NULL pointer dereferences on the road. > > Thanks Christian for testing. > > Since the patch causes problems on your hardware, I don't think it is > good idea to merge it. Yeah, but it would be bad to ignore the problem as well. The way it is now kills any possibility of using DW controller for reading sensors like gyroscope, accelerometer, barometer that have higher sampling rate etc. I'll try to come up with a new patch but since I can't reproduce the problem here it'd be good to know if there's any means for me to test. What do you think that could be done? Maybe putting the controller to sleep only in case of errors? thanks -- Lucas De Marchi????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?