Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932160AbbFXOSP (ORCPT ); Wed, 24 Jun 2015 10:18:15 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:35112 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932118AbbFXOR4 (ORCPT ); Wed, 24 Jun 2015 10:17:56 -0400 Date: Wed, 24 Jun 2015 15:17:50 +0100 From: Lee Jones To: Javier Martinez Canillas Cc: Paul Gortmaker , linux-kernel@vger.kernel.org, Heiko Stuebner , Olof Johansson , Samuel Ortiz Subject: Re: [PATCH] mfd: fix dependency warning for CHROME_PLATFORMS on !X86, !ARM Message-ID: <20150624141750.GQ15013@x1> References: <1434844916-5412-1-git-send-email-paul.gortmaker@windriver.com> <5586027E.50304@collabora.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5586027E.50304@collabora.co.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2258 Lines: 68 On Sun, 21 Jun 2015, Javier Martinez Canillas wrote: > Hello Paul, > > On 06/21/2015 02:01 AM, Paul Gortmaker wrote: > > In commit 062476f24aa7cf714169342cc50626fd9bbb93da ("mfd: cros_ec: > > Move protocol helpers out of the MFD driver") there was a select > > added on CHROME_PLATFORMS, which leads to the following for ppc/mips: > > > > warning: (MFD_CROS_EC) selects CHROME_PLATFORMS which has unmet > > direct dependencies (X86 || ARM) > > > > Right, sorry for missing that and thank a lot for taking care of it. > > > Presumably the above means MFD_CROS_EC is only currently useful > > on x86 and ARM, so lets limit it to there. > > > > That is correct, although I wonder if CHROME_PLATFORMS should not > also depend on || COMPILE_TEST and same for MFD_CROS_EC so those > have at least build coverage on other architectures. > > I can't think for a reason to not be buildable on other archs... Right. Will you fix that Javier? > > Cc: Lee Jones > > Cc: Javier Martinez Canillas > > Cc: Heiko Stuebner > > Cc: Olof Johansson > > Cc: Samuel Ortiz > > Signed-off-by: Paul Gortmaker > > --- > > drivers/mfd/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > > index 653815950aa2..d3235e6f1953 100644 > > --- a/drivers/mfd/Kconfig > > +++ b/drivers/mfd/Kconfig > > @@ -94,6 +94,7 @@ config MFD_AXP20X > > > > config MFD_CROS_EC > > tristate "ChromeOS Embedded Controller" > > + depends on X86 || ARM > > select MFD_CORE > > select CHROME_PLATFORMS > > select CROS_EC_PROTO > > > > ...but that is orthogonal to this patch so: > > Acked-by: Javier Martinez Canillas > > Best regards, > Javier -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/