Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932114AbbFXOVm (ORCPT ); Wed, 24 Jun 2015 10:21:42 -0400 Received: from gloria.sntech.de ([95.129.55.99]:44132 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752161AbbFXOVf (ORCPT ); Wed, 24 Jun 2015 10:21:35 -0400 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Lee Jones Cc: Javier Martinez Canillas , Paul Gortmaker , linux-kernel@vger.kernel.org, Olof Johansson , Samuel Ortiz Subject: Re: [PATCH] mfd: fix dependency warning for CHROME_PLATFORMS on !X86, !ARM Date: Wed, 24 Jun 2015 16:21:23 +0200 Message-ID: <1921214.Eo3JuLmrvN@diego> User-Agent: KMail/4.14.1 (Linux/3.16.0-4-amd64; KDE/4.14.2; x86_64; ; ) In-Reply-To: <20150624141750.GQ15013@x1> References: <1434844916-5412-1-git-send-email-paul.gortmaker@windriver.com> <5586027E.50304@collabora.co.uk> <20150624141750.GQ15013@x1> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1451 Lines: 33 Am Mittwoch, 24. Juni 2015, 15:17:50 schrieb Lee Jones: > On Sun, 21 Jun 2015, Javier Martinez Canillas wrote: > > Hello Paul, > > > > On 06/21/2015 02:01 AM, Paul Gortmaker wrote: > > > In commit 062476f24aa7cf714169342cc50626fd9bbb93da ("mfd: cros_ec: > > > Move protocol helpers out of the MFD driver") there was a select > > > added on CHROME_PLATFORMS, which leads to the following for ppc/mips: > > > > > > warning: (MFD_CROS_EC) selects CHROME_PLATFORMS which has unmet > > > direct dependencies (X86 || ARM) > > > > Right, sorry for missing that and thank a lot for taking care of it. > > > > > Presumably the above means MFD_CROS_EC is only currently useful > > > on x86 and ARM, so lets limit it to there. > > > > That is correct, although I wonder if CHROME_PLATFORMS should not > > also depend on || COMPILE_TEST and same for MFD_CROS_EC so those > > have at least build coverage on other architectures. > > > > I can't think for a reason to not be buildable on other archs... > > Right. Will you fix that Javier? looking at the ChromeOS kernel tree (3.18 / oak) it looks like ARM64 might also be a nice addition to this list, but I'm not sure if there are more ec changes involved. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/