Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753492AbbFXOzB (ORCPT ); Wed, 24 Jun 2015 10:55:01 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:44031 "EHLO out5-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752573AbbFXOyx (ORCPT ); Wed, 24 Jun 2015 10:54:53 -0400 X-Sasl-enc: ZFqsQV5DbE1X9tsFkGC8aRQtTn93eEjW4mFsVpSKPU9d 1435157692 Date: Wed, 24 Jun 2015 07:54:51 -0700 From: Greg KH To: Luis Henriques Cc: Steven Rostedt , Linus Torvalds , LKML , Ingo Molnar , Peter Zijlstra , Vince Weaver , Arnaldo Carvalho de Melo , stable@vger.kernel.org Subject: Re: [GIT PULL] tracing: Have filter check for balanced ops Message-ID: <20150624145451.GC17352@kroah.com> References: <20150617083638.20304e44@gandalf.local.home> <20150622135317.GB2036@ares> <20150622140314.GC2036@ares> <20150622101728.63190cd8@gandalf.local.home> <20150622144940.GD2036@ares> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150622144940.GD2036@ares> User-Agent: Mutt/1.5.23+89 (0255b37be491) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1098 Lines: 33 On Mon, Jun 22, 2015 at 03:49:40PM +0100, Luis Henriques wrote: > On Mon, Jun 22, 2015 at 10:17:28AM -0400, Steven Rostedt wrote: > ... > > To make this patch simpler, just move the "cnt--;" above the OP_AND and > > OP_OR check and remove the "cnt--;" from that if statement. > > > > But yeah, this looks fine. You can test it with the example in the > > change log. > > > > echo "((dev==1)blocks==2)" > events/ext4/ext4_truncate_exit/filter > > > > And see if it gives an error other than "parse_error: No error". > > > > -- Steve > > Thanks Steven, I've done a quick test with a 3.16-ckt kernel and I can > confirm that the modified patch (i.e. including your suggestion) fixes > the problem. > > I'm attaching the patch below and CC'ing stable mailing-list. > > Cheers, > -- > Lu?s Thanks, I've used this patch for 3.10 and 3.14. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/