Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753567AbbFXRKa (ORCPT ); Wed, 24 Jun 2015 13:10:30 -0400 Received: from mail-pd0-f178.google.com ([209.85.192.178]:34554 "EHLO mail-pd0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752443AbbFXRKW (ORCPT ); Wed, 24 Jun 2015 13:10:22 -0400 Message-ID: <558AE478.2080802@linaro.org> Date: Wed, 24 Jun 2015 22:40:16 +0530 From: Vaibhav Hiremath User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Tony Lindgren CC: Linus Walleij , lee.jones@linaro.org, sameo@linux.intel.com, linux-gpio@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" , linux-kernel@vger.kernel.org Subject: Re: Use of pinctrl-single for external device over I2C References: <55893B2C.1070800@linaro.org> <558A9CC7.6070409@linaro.org> <20150624133349.GI4156@atomide.com> In-Reply-To: <20150624133349.GI4156@atomide.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1429 Lines: 45 On Wednesday 24 June 2015 07:03 PM, Tony Lindgren wrote: > * Vaibhav Hiremath [150624 05:06]: >> On Tuesday 23 June 2015 04:25 PM, Vaibhav Hiremath wrote: >>> >>> /* >>> * REVISIT: Reads and writes could eventually use regmap or something >>> * generic. But at least on omaps, some mux registers are performance >>> * critical as they may need to be remuxed every time before and after >>> * idle. Adding tests for register access width for every read and >>> * write like regmap is doing is not desired, and caching the registers >>> * does not help in this case. >>> */ >>> >>> >>> Should be not have flag for this and use regmap_ variants? If we >>> implement flag based approach then same driver can be reused for pinmux >>> configuration of external device. > > Nothing stopping you from adding regmap support to it. It just needs > to be made optional as the users so far don't need it. > Yeah, absolutely. Thinking more on this, I do not like this, as this is not HW feature, so DT may not be right approach. So I will dig more from either runtime or Compile time option to use regmap_ Vs raw read/writes. Thanks, Vaibhav -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/