Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754043AbbFXRa1 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 24 Jun 2015 13:30:27 -0400
Received: from mail-yk0-f179.google.com ([209.85.160.179]:34514 "EHLO
	mail-yk0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754022AbbFXRaU (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 24 Jun 2015 13:30:20 -0400
MIME-Version: 1.0
In-Reply-To: <1434728209-24724-2-git-send-email-jilaiw@codeaurora.org>
References: <1434728209-24724-1-git-send-email-jilaiw@codeaurora.org>
	<1434728209-24724-2-git-send-email-jilaiw@codeaurora.org>
Date: Wed, 24 Jun 2015 13:30:18 -0400
Message-ID: <CAF6AEGtDm6gMkP0fOUfhUNgnoxXFiBa8gcaqck7C_j5Oiw5fnA@mail.gmail.com>
Subject: Re: [PATCH 1/3] drm/doc: Add description of drm properties in msm
From: Rob Clark <robdclark@gmail.com>
To: Jilai Wang <jilaiw@codeaurora.org>
Cc: "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        linux-arm-msm <linux-arm-msm@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2338
Lines: 63

On Fri, Jun 19, 2015 at 11:36 AM, Jilai Wang <jilaiw@codeaurora.org> wrote:
> Add plane properties "premultiplied/zpos/alpha" used in msm MDP
> driver to perform proper blending operation.
>
> Signed-off-by: Jilai Wang <jilaiw@codeaurora.org>
> ---
>  Documentation/DocBook/drm.tmpl | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>
> diff --git a/Documentation/DocBook/drm.tmpl b/Documentation/DocBook/drm.tmpl
> index 109fde8..9dc0940 100644
> --- a/Documentation/DocBook/drm.tmpl
> +++ b/Documentation/DocBook/drm.tmpl
> @@ -3500,6 +3500,29 @@ void intel_crt_init(struct drm_device *dev)
>         <td valign="top" >Plane</td>
>         <td valign="top" >TBD</td>
>         </tr>
> +       <tr>
> +       <td rowspan="3" valign="top" >msm</td>
> +       <td rowspan="3" valign="top" >Generic</td>
> +       <td valign="top" >"premultiplied"</td>
> +       <td valign="top" >RANGE</td>

probably an ENUM property for this?

> +       <td valign="top" >Min=0, Max=1</td>
> +       <td valign="top" >Plane</td>
> +       <td valign="top" >property to indicate the framebuffer used by this plane is alpha pre-multiplied</td>
> +       </tr>
> +       <tr>
> +       <td valign="top" >"alpha"</td>
> +       <td valign="top" >RANGE</td>
> +       <td valign="top" >Min=0, Max=255</td>
> +       <td valign="top" >Plane</td>
> +       <td valign="top" >property to set plane's global alpha value</td>
> +       </tr>
> +       <tr>
> +       <td valign="top" >"zpos"</td>
> +       <td valign="top" >RANGE</td>
> +       <td valign="top" >Min=1, Max=255</td>
> +       <td valign="top" >Plane</td>
> +       <td valign="top" >property to set plane's z position during blending</td>

looks like we already have alpha and zpos props..  although it
wouldn't hurt to copy your description over for those props, since it
is a bit more complete than "TBD" that we have currently

BR,
-R

> +       </tr>
>         </tbody>
>         </table>
>      </sect2>
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/