Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753592AbbFXTXw (ORCPT ); Wed, 24 Jun 2015 15:23:52 -0400 Received: from mta-out1.inet.fi ([62.71.2.229]:41750 "EHLO johanna4.inet.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752884AbbFXTXq (ORCPT ); Wed, 24 Jun 2015 15:23:46 -0400 RazorGate-KAS: Rate: 5 RazorGate-KAS: {RECEIVED: dynamic ip detected} RazorGate-KAS: Envelope from: RazorGate-KAS: Version: 5.5.3 RazorGate-KAS: LuaCore: 215 2015-05-29_17-31-22 60ae4a1b4d01d14f868b20a55aced8d7df7b2e28 RazorGate-KAS: Method: none RazorGate-KAS: Lua profiles 78662 [Jun 02 2015] RazorGate-KAS: Status: not_detected Date: Wed, 24 Jun 2015 22:23:13 +0300 From: "Kirill A. Shutemov" To: Oleg Nesterov Cc: Andy Lutomirski , Andrew Morton , Al Viro , Benjamin LaHaise , Hugh Dickins , Jeff Moyer , Kirill Shutemov , Linus Torvalds , "linux-kernel@vger.kernel.org" , Andy Lutomirski , Pavel Emelyanov Subject: Re: [PATCH 1/1] mm: move ->mremap() from file_operations to vm_operations_struct Message-ID: <20150624192313.GA19249@node.dhcp.inet.fi> References: <20150623180225.GA12882@redhat.com> <20150623180251.GA13131@redhat.com> <20150623181945.GA13390@node.dhcp.inet.fi> <20150623182655.GA21392@redhat.com> <20150624154914.GA6127@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150624154914.GA6127@redhat.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1670 Lines: 49 On Wed, Jun 24, 2015 at 05:49:14PM +0200, Oleg Nesterov wrote: > On 06/23, Oleg Nesterov wrote: > > > > On 06/23, Kirill A. Shutemov wrote: > > > > > > On Tue, Jun 23, 2015 at 08:02:51PM +0200, Oleg Nesterov wrote: > > > > vma->vm_ops->mremap() looks more natural and clean in move_vma(), > > > > and this way ->mremap() can have more users. Say, vdso. > > > > > > > > Signed-off-by: Oleg Nesterov > > > > --- > > > > fs/aio.c | 25 ++++++++++++++++--------- > > > > include/linux/fs.h | 1 - > > > > include/linux/mm.h | 1 + > > > > mm/mremap.c | 4 ++-- > > > > > > Please, update Documentation/filesystems/Locking. > > > > OK, thanks, will do. > > Wait... Documentation/filesystems/Locking doesn't mention > ->mremap() at all. > > So you actually ask me to add the new documentation? ;) I tried ;) > Oh well... OK, I'll try if you think this is necessary. > > I tried to make the minimal change before ->mremap() finds another > user in file_operations. I thinks it needs more arguments, at least > new_addr and new_len, otherwise it is not easy to document it. The > same for f_op->mremap() of course. > > Currently this does not matter, the only user is aio.c and > VM_DONTEXPAND means that it is not mergeable, so mremap() always > creates the new vma. > > Hmm. Can't we do this change and add the documentation later? I'm fine with that. -- Kirill A. Shutemov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/