Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751425AbbFXVMJ (ORCPT ); Wed, 24 Jun 2015 17:12:09 -0400 Received: from www.linutronix.de ([62.245.132.108]:46202 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750879AbbFXVMB (ORCPT ); Wed, 24 Jun 2015 17:12:01 -0400 Date: Wed, 24 Jun 2015 23:10:42 +0200 (CEST) From: Thomas Gleixner To: Julia Lawall cc: Jiang Liu , Bjorn Helgaas , Benjamin Herrenschmidt , Ingo Molnar , "H. Peter Anvin" , "Rafael J. Wysocki" , Randy Dunlap , Yinghai Lu , Borislav Petkov , Jason Cooper , Kevin Cernekee , Arnd Bergmann , Marc Zyngier , Konrad Rzeszutek Wilk , Tony Luck , x86@kernel.org, LKML , linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [RFC v1 14/25] genirq: Kill the first parameter 'irq' of irq_flow_handler_t In-Reply-To: Message-ID: References: <1432116013-25902-1-git-send-email-jiang.liu@linux.intel.com> <1432116013-25902-15-git-send-email-jiang.liu@linux.intel.com> <555CA834.7080807@linux.intel.com> <557C5F29.7010301@linux.intel.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2454 Lines: 98 On Sat, 13 Jun 2015, Julia Lawall wrote: > On Sat, 13 Jun 2015, Thomas Gleixner wrote: > > > On Sat, 13 Jun 2015, Julia Lawall wrote: > > > > > The following are the cases that require some manual attention, either > > > because the handler is a local variable or because it is some other kind > > > of expression. > > > > yep, found it in the logs already and found a missing search expression: > > > > | > > gpiochip_set_chained_irqchip@p(e1,e2,e3,\(lih\|ih\|eh\)) > > > > This is really impressive work!!!! > > Thanks :) > > I'll add the above pattern, but I guess you already have the results for > that case. Yes. I did some more experiments and analyzed all functions which have the signature [static] void f(T irq, struct irq_desc *desc) where T is either 'unsigned int' or 'u32' That throws up a handful of false positives, but those are functions which are called from a real handler function, so we want to look at those anyway. Now where my cocci foo ends is when I try to match both types in the same rule, i.e. @ fun exists @ identifier hf,irq,desc; typedef u32; @@ ( void hf(unsigned irq, struct irq_desc *desc) { ... } | void hf(u32 irq, struct irq_desc *desc) { ... } ) results in: Fatal error: exception Failure("minus: parse error: = File "../cocci/find-pot-handler.cocci", line 7, column 5, charpos = 63 around = 'hf', whole content = void hf(unsigned irq, struct irq_desc *desc) { ... } ") I tried a couple of other variants, but finally gave up and ran a cocci script first which does s/u32/unsigned/ on those functions, but of course because I'm lazy I wanted to do everything in one go. :) Aside of that the ruleset you gave me works nicely except for that part: // no uses of the first parameter before the assignment @@ identifier fun.hf,irq; expression e; type T; fresh identifier firq = "__" ## irq; position r.p,p1 != {s.p1,s1.p1}; @@ hf(T@p - irq + firq ,...) { ... when != irq when strict ? irq@p1 = e ... when any } That lacks a: + unsigned int irq; and therefor missed to add the local variable 'unsigned int irq' in case the parameter is only used for local storage. That was simple enough to fix even for me :) Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/