Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751732AbbFXV3m (ORCPT ); Wed, 24 Jun 2015 17:29:42 -0400 Received: from casper.infradead.org ([85.118.1.10]:40365 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750879AbbFXV3h (ORCPT ); Wed, 24 Jun 2015 17:29:37 -0400 Date: Wed, 24 Jun 2015 23:29:30 +0200 From: Peter Zijlstra To: Stephen Boyd Cc: Catalin Marinas , Will Deacon , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, John Stultz , Steven Rostedt , "Paul E. McKenney" , Nicolas Pitre Subject: Re: [PATCH] ARM64: smp: Silence suspicious RCU usage with ipi tracepoints Message-ID: <20150624212930.GC12596@twins.programming.kicks-ass.net> References: <1435176858-9568-1-git-send-email-sboyd@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1435176858-9568-1-git-send-email-sboyd@codeaurora.org> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 853 Lines: 17 On Wed, Jun 24, 2015 at 01:14:18PM -0700, Stephen Boyd wrote: > John Stultz reported an RCU splat on ARM with ipi trace events > enabled. It looks like the same problem exists on ARM64. > > At this point in the IPI handling path we haven't called > irq_enter() yet, so RCU doesn't know that we're about to exit > idle and properly warns that we're using RCU from an idle CPU. > Use trace_ipi_entry_rcuidle() instead of trace_ipi_entry() so > that RCU is informed about our exit from idle. I have a problem with $subject. It says 'silence', whereas afaict this fixes an actual bug, so it should be 'fixes'. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/