Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752217AbbFYAHg (ORCPT ); Wed, 24 Jun 2015 20:07:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41747 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751123AbbFYAH3 (ORCPT ); Wed, 24 Jun 2015 20:07:29 -0400 Message-ID: <558B463F.5050200@redhat.com> Date: Wed, 24 Jun 2015 17:07:27 -0700 From: Laura Abbott User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Mark Rutland , Laura Abbott CC: Russell King , Arnd Bergmann , Nicolas Pitre , Stefan Agner , Catalin Marinas , Will Deacon , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Hans de Goede Subject: Re: [PATCH] arm: Update memblock limit after mapping lowmem References: <1433445349-12497-1-git-send-email-labbott@fedoraproject.org> <20150611130700.GA8153@leverpostej> In-Reply-To: <20150611130700.GA8153@leverpostej> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2073 Lines: 62 On 06/11/2015 06:07 AM, Mark Rutland wrote: > On Thu, Jun 04, 2015 at 08:15:49PM +0100, Laura Abbott wrote: >> >> The memblock limit is currently used in find_limits >> to find the bounds for ZONE_NORMAL. The memblock >> limit may need to be rounded down a PMD size to ensure >> allocations are fully mapped though. This has the side >> effect of reducing the amount of memory in ZONE_NORMAL. >> Once all lowmem is mapped, it's safe to change the memblock >> limit back to include the unaligned section. Adjust the >> memblock limit after lowmem mapping is complete. >> >> Before: >> # cat /proc/zoneinfo | grep managed >> managed 62907 >> managed 424 >> >> After: >> # cat /proc/zoneinfo | grep managed >> managed 63331 >> >> Signed-off-by: Laura Abbott >> --- >> This is a replacement for >> 'arm: Don't use memblock limit for the lowmem bound' which >> doesn't actually work on NOMMU systems. > > Works for me on TC2, atop v4.1-rc7. Before this patch, with a few byes > carved out of the memory node I would see: > > Memory: 1030380K/1046528K available (4832K kernel code, 154K rwdata, 1376K rodata, 260K init, 147K bss, 16148K reserved, 0K cma-reserved) > > $ cat /proc/zoneinfo | grep managed > managed 257660 > > With the patch I see: > > Memory: 1032424K/1048572K available (4832K kernel code, 154K rwdata, 1376K rodata, 260K init, 147K bss, 16148K reserved, 0K cma-reserved) > > $ cat /proc/zoneinfo | grep managed > managed 258171 > > The patch itself looks good to me. > > Reviewed-by: Mark Rutland > Tested-by: Mark Rutland > > Thanks, > Mark. > FYI, I put this in the patch tracker. I was on vacation when the Reviewed-by/Tested-by came in so I'm only getting to it now. Thanks, Laura -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/