Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752189AbbFYAPT (ORCPT <rfc822;w@1wt.eu>);
	Wed, 24 Jun 2015 20:15:19 -0400
Received: from mailgw01.mediatek.com ([210.61.82.183]:51233 "EHLO
	mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org
	with ESMTP id S1751847AbbFYAPN (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 24 Jun 2015 20:15:13 -0400
X-Listener-Flag: 11101
Message-ID: <1435191308.28046.1.camel@mtkswgap22>
Subject: Re: [PATCH 2/2] ARM: dts: mediatek: add mt6580 basic support
From: Mars Cheng <mars.cheng@mediatek.com>
To: Matthias Brugger <matthias.bgg@gmail.com>
CC: <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
        <linux-mediatek@lists.infradead.org>,
        Yingjoe Chen <yingjoe.chen@mediatek.com>,
        CC Hwang <cc.hwang@mediatek.com>, Jades Shih <jades.shih@mediatek.com>,
        Loda Chou <loda.chou@mediatek.com>,
        Miles Chen <miles.chen@mediatek.com>,
        MY Chuang <my.chuang@mediatek.com>, Scott Shu <scott.shu@mediatek.com>
Date: Thu, 25 Jun 2015 08:15:08 +0800
In-Reply-To: <2753320.5M4yQIm8Im@ubix>
References: <1433319533-24803-1-git-send-email-mars.cheng@mediatek.com>
	 <3799922.TWv12CPu81@ubix> <1435147153.3792.9.camel@mtkswgap22>
	 <2753320.5M4yQIm8Im@ubix>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.2.3-0ubuntu6 
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MTK: N
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1019
Lines: 30

On Wed, 2015-06-24 at 22:25 +0200, Matthias Brugger wrote:
> On Wednesday, June 24, 2015 07:59:13 PM Mars Cheng wrote:
> > On Tue, 2015-06-23 at 21:45 +0200, Matthias Brugger wrote:
> > > > +	soc {
> > > 
> > > Please drop the soc node as well and just add the components directly.
> > > 
> > > Thanks,
> > > Matthias
> > 
> > May I know the reason to remove the soc node? I follow other xxxx.dtsi
> > to add this node.
> 
> The device tree is reflecting the hardware, if you add a soc node like this, it 
> is seen like a bus, but there is not really a bus.
> 
> I think point of view about this has change over time and nowadays it is 
> preferred not to add a soc node.
> 
> Regards,
> Matthias
Got it. Will remove the soc node and prepare the new patch.

Thanks a lot.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/