Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751272AbbFYFNG (ORCPT ); Thu, 25 Jun 2015 01:13:06 -0400 Received: from muru.com ([72.249.23.125]:59640 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750940AbbFYFM7 (ORCPT ); Thu, 25 Jun 2015 01:12:59 -0400 Date: Wed, 24 Jun 2015 22:12:53 -0700 From: Tony Lindgren To: Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, Pali =?utf-8?B?Um9ow6Fy?= , Ivaylo Dimitrov , Russell King , Sebastian Reichel , Will Deacon , linux-kernel@vger.kernel.org, Pavel Machek , linux-omap@vger.kernel.org, Andreas =?utf-8?Q?F=C3=A4rber?= Subject: Re: [PATCH 2/2] arm: boot: store ATAG structure into DT atags field Message-ID: <20150625051253.GN4156@atomide.com> References: <1430902142-17035-1-git-send-email-pali.rohar@gmail.com> <3513646.XX80DTTJbc@wuerfel> <201505152216.24622@pali> <46811670.AspmkHD9JS@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <46811670.AspmkHD9JS@wuerfel> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2005 Lines: 54 * Arnd Bergmann [150515 13:23]: > On Friday 15 May 2015 22:16:24 Pali Rohár wrote: > > On Friday 15 May 2015 22:12:41 Arnd Bergmann wrote: > > > On Friday 15 May 2015 21:50:07 Pali Rohár wrote: > > > > } > > > > > > > > } > > > > > > > > + /* include the terminating ATAG_NONE */ > > > > + atag_size = (char *)atag - (char *)atag_list + > > > > sizeof(struct tag_header); + setprop(fdt, "/", "atags", > > > > atag_list, atag_size); > > > > + > > > > > > > > if (memcount) { > > > > > > > > setprop(fdt, "/memory", "reg", mem_reg_property, > > > > > > > > 4 * memcount * memsize); > > > > > > The property should probably have a DT binding, and be named > > > "linux,atags". > > > > > > It may also help to check if the "linux,atags" property already > > > exists and not create it otherwise. That way we can put it into the > > > n900 dts file and have it updated by the compat code, but not expose > > > the atags on other platforms unless they opt in. Using "linux,atags" sounds good to me. And yes checking it with getprop before doing setprop makes sense. > > Maybe what would help: Is there a way to tell decompressor/kernel to not > > touch atag memory and then after kernel/board-code starts it save copy > > of atags? I think it is not possible right now, but correct me if I'm > > wrong... > > > > I don't think that is possible without an incompatible change to the > boot protocol. Agreed, let's keep the changes to minimum. Looks like with the comments posted all the pending four patches from Pali become quite a minimal set of three patches if we keep the rev string as hex. Regrds, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/