Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751174AbbFYF03 (ORCPT ); Thu, 25 Jun 2015 01:26:29 -0400 Received: from mail-pa0-f52.google.com ([209.85.220.52]:36555 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750777AbbFYF0X (ORCPT ); Thu, 25 Jun 2015 01:26:23 -0400 Message-ID: <558B90F7.80700@linaro.org> Date: Thu, 25 Jun 2015 10:56:15 +0530 From: Vaibhav Hiremath User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Krzysztof Kozlowski CC: linux-arm-kernel@lists.infradead.org, Zhao Ye , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, lee.jones@linaro.org Subject: Re: [PATCH-v3 2/3] mfd: 88pm800: Allow configuration of interrupt clear method References: <1435137673-1629-1-git-send-email-vaibhav.hiremath@linaro.org> <1435137673-1629-3-git-send-email-vaibhav.hiremath@linaro.org> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1408 Lines: 47 On Thursday 25 June 2015 05:33 AM, Krzysztof Kozlowski wrote: > 2015-06-24 18:21 GMT+09:00 Vaibhav Hiremath : >> As per the spec, bit 1 (INT_CLEAR_MODE) of reg addr 0xe >> (page 0) controls the method of clearing interrupt >> status of 88pm800 family of devices; >> >> 0: clear on read >> 1: clear on write >> >> This patch allows to configure this field, through DT. >> >> Also, as suggested by "Lee Jones" renaming DT property and variable >> field to appropriate name. >> >> Signed-off-by: Zhao Ye >> Signed-off-by: Vaibhav Hiremath > > It does not look like a property of the board. Instead it looks like a > runtime configuration so it should not be part of DT bindings. > Why do you say that? It is very well feature of 88PM860 device, where you can control irq clear operation (either read/write). Thanks, Vaibhav > I understand that previously this was configured by platform data and > now you want to move everything to DT. But this does not belong to > DT... > Thats not completely true. I think DT is the right place for this configuration. Thanks, Vaibhav -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/