Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751893AbbFYIil (ORCPT ); Thu, 25 Jun 2015 04:38:41 -0400 Received: from mail-wg0-f53.google.com ([74.125.82.53]:36690 "EHLO mail-wg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751207AbbFYIif (ORCPT ); Thu, 25 Jun 2015 04:38:35 -0400 Date: Thu, 25 Jun 2015 09:38:30 +0100 From: Lee Jones To: Javier Martinez Canillas Cc: linux-samsung-soc@vger.kernel.org, Heiko Stuebner , Paul Gortmaker , Gwendal Grignou , Doug Anderson , linux-kernel@vger.kernel.org, Samuel Ortiz , Olof Johansson Subject: Re: [PATCH 3/3] mfd: Remove MFD_CROS_EC_SPI depends on OF Message-ID: <20150625083830.GU15013@x1> References: <1435191645-6022-1-git-send-email-javier.martinez@collabora.co.uk> <1435191645-6022-4-git-send-email-javier.martinez@collabora.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1435191645-6022-4-git-send-email-javier.martinez@collabora.co.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1519 Lines: 43 On Thu, 25 Jun 2015, Javier Martinez Canillas wrote: > The ChromeOS EC SPI transport driver has a dependency on OF because it > uses some OF helpers from the header. But there isn't a > need for an explicit dependency since the header has stub functions if > CONFIG_OF is not defined. > > Also, MFD_CROS_EC_SPI already depends on MFD_CROS_EC which in turn has > a dependency on OF so in practice can't be selected without CONFIG_OF. > > Signed-off-by: Javier Martinez Canillas > > --- > > drivers/mfd/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied for v4.3, thanks. > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index 653815950aa2..3f68dd251ce8 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -115,7 +115,7 @@ config MFD_CROS_EC_I2C > > config MFD_CROS_EC_SPI > tristate "ChromeOS Embedded Controller (SPI)" > - depends on MFD_CROS_EC && CROS_EC_PROTO && SPI && OF > + depends on MFD_CROS_EC && CROS_EC_PROTO && SPI > > ---help--- > If you say Y here, you get support for talking to the ChromeOS EC -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/