Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752065AbbFYJSW (ORCPT ); Thu, 25 Jun 2015 05:18:22 -0400 Received: from mail-yh0-f46.google.com ([209.85.213.46]:35328 "EHLO mail-yh0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751671AbbFYJSO (ORCPT ); Thu, 25 Jun 2015 05:18:14 -0400 MIME-Version: 1.0 X-Originating-IP: [37.11.0.18] In-Reply-To: <20150625084204.GW15013@x1> References: <1435154348-28840-1-git-send-email-lee.jones@linaro.org> <1435154348-28840-8-git-send-email-lee.jones@linaro.org> <20150625084204.GW15013@x1> Date: Thu, 25 Jun 2015 11:18:13 +0200 Message-ID: Subject: Re: [PATCH v2 7/9] ARM: multi_v7_defconfig: Enable support for PWM Regulators From: Javier Martinez Canillas To: Lee Jones Cc: "linux-arm-kernel@lists.infradead.org" , Linux Kernel , "devicetree@vger.kernel.org" , kernel@stlinux.com, "linux-pm@vger.kernel.org" , Viresh Kumar , "Rafael J. Wysocki" , Ajit Pal Singh Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1203 Lines: 36 Hello Lee, On Thu, Jun 25, 2015 at 10:42 AM, Lee Jones wrote: > On Wed, 24 Jun 2015, Javier Martinez Canillas wrote: [...] >> > diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig >> > index f632af0..6666973 100644 >> > --- a/arch/arm/configs/multi_v7_defconfig >> > +++ b/arch/arm/configs/multi_v7_defconfig >> > @@ -365,6 +365,7 @@ CONFIG_REGULATOR_MAX8907=y >> > CONFIG_REGULATOR_MAX8973=y >> > CONFIG_REGULATOR_MAX77686=y >> > CONFIG_REGULATOR_PALMAS=y >> > +CONFIG_REGULATOR_PWM=y >> >> The current policy is to build as much as possible as a module in >> multi_v7_defconfig. Since this is a tristate Kconfig symbol, could you >> please change it to =m ? > > I would prefer that it stays built-in. > Ok, I've no strong opinion on this. I was just mentioning what arm-soc maintainers prefer nowadays. May I ask what's the rationale for leaving this option built-in? Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/