Subject: Re: [PATCH V2 1/1] usb:serial:f81534 Add F81532/534 Driver
To: Johan Hovold <johan@kernel.org>
References: <1434333267-10054-1-git-send-email-hpeter+linux_kernel@gmail.com>
 <558B8EC8.10806@gmail.com> <20150625080607.GA28464@localhost>
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org, peter_hong@fintek.com.tw,
        tom_tsai@fintek.com.tw, Peter Hung <hpeter+linux_kernel@gmail.com>
From: Peter Hung <hpeter@gmail.com>
Message-ID: <558BC7FD.100@gmail.com>
Date: Thu, 25 Jun 2015 17:21:01 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.0.1
MIME-Version: 1.0
In-Reply-To: <20150625080607.GA28464@localhost>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 978
Lines: 27

Hi Johan,

Johan Hovold 於 2015/6/25 下午 04:06 寫道:
>   - As Greg already mentioned, you need to implement gpio support using
>     gpiolib, not a custom sysfs interface
>
> I don't have time to look closer at the architectural bits until next
> week I'm afraid, but perhaps you could start with the above.

Thanks for your advices, I'll try to improve it again.
But I had something need to clarify.

1. The sysfs interface of the driver provide "limited output pin"
    control. only support output 0/1, not support input mode.
    Should I implement it as gpiolib?

2. If it still recommends to implement with gpiolib, Could I implement
    it and preserve the sysfs interface for legacy?

-- 
With Best Regards,
Peter Hung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/