Date: Thu, 25 Jun 2015 11:25:47 +0200
From: Johan Hovold <johan@kernel.org>
To: Peter Hung <hpeter@gmail.com>
Cc: Johan Hovold <johan@kernel.org>, gregkh@linuxfoundation.org,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        peter_hong@fintek.com.tw, tom_tsai@fintek.com.tw,
        Peter Hung <hpeter+linux_kernel@gmail.com>
Subject: Re: [PATCH V2 1/1] usb:serial:f81534 Add F81532/534 Driver
Message-ID: <20150625092547.GB28464@localhost>
References: <1434333267-10054-1-git-send-email-hpeter+linux_kernel@gmail.com>
 <558B8EC8.10806@gmail.com>
 <20150625080607.GA28464@localhost>
 <558BC7FD.100@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <558BC7FD.100@gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1136
Lines: 31

On Thu, Jun 25, 2015 at 05:21:01PM +0800, Peter Hung wrote:
> Hi Johan,
> 
> Johan Hovold 於 2015/6/25 下午 04:06 寫道:
> >   - As Greg already mentioned, you need to implement gpio support using
> >     gpiolib, not a custom sysfs interface
> >
> > I don't have time to look closer at the architectural bits until next
> > week I'm afraid, but perhaps you could start with the above.
> 
> Thanks for your advices, I'll try to improve it again.
> But I had something need to clarify.
> 
> 1. The sysfs interface of the driver provide "limited output pin"
>     control. only support output 0/1, not support input mode.
>     Should I implement it as gpiolib?

Yes.

> 2. If it still recommends to implement with gpiolib, Could I implement
>     it and preserve the sysfs interface for legacy?

No, I'm afraid not. We don't want to have to maintain out-of-tree legacy
interfaces.

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/