Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753326AbbFYKEG (ORCPT ); Thu, 25 Jun 2015 06:04:06 -0400 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:55536 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752341AbbFYKDF (ORCPT ); Thu, 25 Jun 2015 06:03:05 -0400 Date: Thu, 25 Jun 2015 11:02:45 +0100 From: Russell King - ARM Linux To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Rob Herring , Will Deacon , Ivaylo Dimitrov , Sebastian Reichel , Pavel Machek , Tony Lindgren , Andreas =?iso-8859-1?Q?F=E4rber?= , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 0/2] ARM: /proc/atags: Export also for DT Message-ID: <20150625100244.GA7576@n2100.arm.linux.org.uk> References: <1430902142-17035-1-git-send-email-pali.rohar@gmail.com> <1431719407-18230-1-git-send-email-pali.rohar@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1431719407-18230-1-git-send-email-pali.rohar@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1236 Lines: 29 On Fri, May 15, 2015 at 09:50:05PM +0200, Pali Roh?r wrote: > This patch adds support for DT "/atags" and stores ATAG structure to DT. > > It depends on "ARM: /proc/cpuinfo: DT: Add support for Revision" patches. > > Pali Roh?r (2): > arm: devtree: Save atags if are in DT atags field > arm: boot: store ATAG structure into DT atag field > > arch/arm/boot/compressed/atags_to_fdt.c | 6 +++++- > arch/arm/kernel/devtree.c | 6 ++++++ > 2 files changed, 11 insertions(+), 1 deletion(-) What these patches are missing is a description of _why_ this is required in any of the commit messages. The commit messages seem to be describing _what_ the change is doing, which is something that can be seen by reading the patches, but it leaves the question of why this change is necessary entirely open. Please update the commit messages on the next patch revision. -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/