Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752712AbbFYKdB (ORCPT ); Thu, 25 Jun 2015 06:33:01 -0400 Received: from alln-iport-2.cisco.com ([173.37.142.89]:7592 "EHLO alln-iport-2.cisco.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751692AbbFYKcy convert rfc822-to-8bit (ORCPT ); Thu, 25 Jun 2015 06:32:54 -0400 X-Greylist: delayed 569 seconds by postgrey-1.27 at vger.kernel.org; Thu, 25 Jun 2015 06:32:54 EDT X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0DFAwCy1YtV/4sNJK1bgxGBMwa4YYNFZgmHXgKBPDgUAQEBAQEBAYEKhCMBAQQ6PxACAQg2EDIlAgQBDQWIL81sAQEBAQEBAQEBAQEBAQEBAQEBAQEBF4tKgT0Bg0gHhCsBBIVaB44kAYtQmDgmY4E2gWFvgUaBAgEBAQ X-IronPort-AV: E=Sophos;i="5.13,675,1427760000"; d="scan'208";a="162502287" From: "Narsimhulu Musini (nmusini)" To: Maninder Singh , "Sesidhar Baddela (sebaddel)" , "JBottomley@odin.com" , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" CC: "pankaj.m@samsung.com" Subject: Re: [PATCH 1/1] scsi/snic: fixing the error print Thread-Topic: [PATCH 1/1] scsi/snic: fixing the error print Thread-Index: AQHQryzsx624wPqjTEapIRFOpQnPJp29s5aA Date: Thu, 25 Jun 2015 10:23:23 +0000 Message-ID: References: <1435225936-10250-1-git-send-email-maninder1.s@samsung.com> In-Reply-To: <1435225936-10250-1-git-send-email-maninder1.s@samsung.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.127.149.231] Content-Type: text/plain; charset="us-ascii" Content-ID: <7E2069CFBF3F474BBD3D0992B4F577EB@emea.cisco.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 751 Lines: 20 On 25/06/15 3:22 pm, "Maninder Singh" wrote: >Currently SNIC_HOST_ERR is called in both cases >whether snic_disc_start returns zero or non-zero. > >From the code it looks like it has to print only if >snic_disc_start return non-zero value, So calling >SNIC_HOST_ERR only for non-zero return from snic_disc_start. > >Signed-off-by: Maninder Singh >Reviewed-by: Rohit Thapliyal Acked-by: Narsimhulu Musini -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/