Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752948AbbFYK2h (ORCPT ); Thu, 25 Jun 2015 06:28:37 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:35105 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751984AbbFYK22 (ORCPT ); Thu, 25 Jun 2015 06:28:28 -0400 Date: Thu, 25 Jun 2015 11:28:23 +0100 From: Lee Jones To: Vaibhav Hiremath Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, yizhang@marvell.com Subject: Re: [PATCH-v4 3/3] mfd: devicetree: bindings: Add new 88pm800 mfd binding Message-ID: <20150625102823.GD15013@x1> References: <1435217189-19578-1-git-send-email-vaibhav.hiremath@linaro.org> <1435217189-19578-4-git-send-email-vaibhav.hiremath@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1435217189-19578-4-git-send-email-vaibhav.hiremath@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2733 Lines: 87 On Thu, 25 Jun 2015, Vaibhav Hiremath wrote: > With addition of DT support to 88pm800 mfd driver, this patch > adds new DT binding documentation along with respective properties. > > Signed-off-by: Vaibhav Hiremath > --- > Documentation/devicetree/bindings/mfd/88pm800.txt | 54 +++++++++++++++++++++++ > 1 file changed, 54 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/88pm800.txt > > diff --git a/Documentation/devicetree/bindings/mfd/88pm800.txt b/Documentation/devicetree/bindings/mfd/88pm800.txt > new file mode 100644 > index 0000000..f56b751 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/88pm800.txt > @@ -0,0 +1,54 @@ > +* Marvell 88PM8xx Power Management IC > + > +Required parent device properties: > +- compatible : "marvell,88pm800", "marvell,88pm805", "marvell,88pm860" > +- reg : the I2C slave address for the 88pm8xx chip > +- interrupts : IRQ line for the 88pm8xx chip > +- interrupt-controller: describes the 88pm8xx as an interrupt controller > +- #interrupt-cells : should be 1. > + - The cell is the 88pm8xx local IRQ number Might just be a personal thing, but I would line up the ':', it's much easier on the eyes that way. > +88pm8xx family of devices consists of varied group of sub-devices: > + > +Device Supply Names Description > +------ ------------ ----------- > +88pm80x-onkey : : On key > +88pm80x-rtc : : RTC > +88pm80x-regulator : : Regulators > + > +Note: More device list will follow No real need for this. > +Example: > + > + pmic: 88pm800@30 { > + compatible = "marvell,88pm800"; > + reg = <0x30>; > + interrupts = ; > + interrupt-parent = <&gic>; > + interrupt-controller; > + #interrupt-cells = <1>; > + > + regulators { > + compatible = "marvell,88pm80x-regulator"; > + > + buck1a: BUCK1A { > + regulator-name = "BUCK1A"; > + regulator-min-microvolt = <600000>; > + regulator-max-microvolt = <1800000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + ldo1: LDO1 { > + regulator-name = "LDO1"; > + regulator-min-microvolt = <1700000>; > + regulator-max-microvolt = <3300000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + }; > + > + rtc { > + compatible = "marvell,88pm80x-rtc"; > + }; > + }; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/