Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752127AbbFYLDA (ORCPT <rfc822;w@1wt.eu>);
	Thu, 25 Jun 2015 07:03:00 -0400
Received: from mout.web.de ([212.227.15.3]:49474 "EHLO mout.web.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751764AbbFYLCy (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 25 Jun 2015 07:02:54 -0400
Message-ID: <558BDFD4.9060301@web.de>
Date: Thu, 25 Jun 2015 13:02:44 +0200
From: Jan Kiszka <jan.kiszka@web.de>
User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666
MIME-Version: 1.0
To: Hui Wang <hui.wang@canonical.com>,
        Raymond Yau <superquad.vortex2@gmail.com>, alex.hung@canonical.com,
        Henrique de Moraes Holschuh <hmh@hmh.eng.br>
CC: ALSA Development Mailing List <alsa-devel@alsa-project.org>,
        Hui Wang <jason77.wang@gmail.com>, tiwai@suse.de,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        yk@canonical.com, david.henningsson@canonical.com
Subject: Re: [alsa-devel] [V2 PATCH] ALSA: hda - Enable mute/mic-mute LEDs
 for more Thinkpads with Conexant codec
References: <1385534846-20829-1-git-send-email-hui.wang@canonical.com>	<53AFF992.5030403@web.de>	<53B0C596.6090007@canonical.com>	<53B1078B.4090101@web.de>	<53B219DF.6090807@canonical.com>	<53B26575.1000003@web.de>	<53B27ED7.4070401@canonical.com>	<53B50062.30200@web.de>	<53B51B63.8060809@canonical.com>	<53B51CF3.8090102@web.de>	<53B52146.9050300@canonical.com>	<55603F22.8070103@web.de> <CAN8cciZYZ4setSj7dgPqQUVrBrr98tSvofLrD_0zvyQqkWfd2Q@mail.gmail.com> <5560A93E.7060607@web.de> <558A4216.8010401@web.de> <558A6E80.7010003@canonical.com>
In-Reply-To: <558A6E80.7010003@canonical.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="xQXeMThDWE7q28gpoIgwVUJrQ22x1XJDA"
X-Provags-ID: V03:K0:BveM4keeu+MQjyNkYj1lRk/dw+M5in2H2rfzt+9CFA9rHVeGRyt
 jySLbmuLU5rMbwjxy5sQfNn2o+YMQ/06iG6QxgxRs3DabxSW3AcFu1vqHceTxJiDXGY1P/n
 zonB01AvEeUwYHx/REDLdIY0/FaBCJ1s72UdrmKyYjvQOPjZH4kFFkqlk5tKkxZ6f3rt5tz
 cCoI+MKJRx4qcSLPvZsCQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:r2b80B70qa0=:7acGEtzD7crlGgeEq+X8Z2
 K8GbMKRormtc/V4b0DTsVK6Gs6Kn5bN0BTWfWhhqRu9O5UwAIPixsd34BFBWgds67L+RGomz7
 oAJ5doTbWF2FAtlC0Qjv67mh/xOnL176Z/PFHic5tUumuv3QL0B31Zurt0E384NrxYHiMBlVz
 PivuK8/gjvApp8DwcngmE8/xlOkJz2EaujJdUILeJAbKUcstZou5QbMK+xb9TjmuY0tCSoQUE
 ygS6a9RNDRG0LTO+35B6O02+YvKTy5N3qJbHflVXwivDOaV/y1mVKtEm/dCBIdaMGCQJY09+Q
 KHko4lqooDg+E2u6B0WVBBoL1Znmw/T0emk/pSXdwfIrZgrUnHDsSzazJ/MbVydi41zSDN5bp
 RZcN80lBeZbKR8k8OGPhIVmqxvo5M77rkFeu3bliDLaK6/thQZ5igeJis+uenkDvjaPxqY3RC
 OhKj+xufwMZmWpEpo8KVjNUIZvR02IzJFNSaPTAzyLHPNCKyVlsLWd73qiXjUjzQ5z9k8u2Vv
 SXrFNrszy0Tm/ahXFo8/lTK9Pk5ssyykm3YTtuY462d2hayyevzvpEI3Eln1MGwNPYJhJYf+e
 wr5Lnehit+FxkkTwUVPs2qyBlPres481Cdcr0eoox1f2VtSWWERRz6tr6qB1St/T5OKOwP3kc
 hvC2lVbThOpHl0pcNBUKUhzugpInFKLN3XaSyqvl+w/vKcg==
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 4521
Lines: 132

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--xQXeMThDWE7q28gpoIgwVUJrQ22x1XJDA
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 2015-06-24 10:46, Hui Wang wrote:
> On 06/24/2015 01:37 PM, Jan Kiszka wrote:
>> On 2015-05-23 18:22, Jan Kiszka wrote:
>>> On 2015-05-23 18:06, Raymond Yau wrote:
>>>> 2015-5-23 =E4=B8=8B=E5=8D=884:50 =E6=96=BC "Jan Kiszka" <jan.kiszka@=
web.de> =E5=AF=AB=E9=81=93=EF=BC=9A
>>>>>>>>>>>>>>>> Most Thinkpad Edge series laptops use conexant codec, so=

>>>>>>>>>>>>>>>> far
>>>>>>>>>>>>>>>> although
>>>>>>>>>> <snip>
>>>>>>>>>>>>> Is there anything I can debug or any information I can coll=
ect
>>>>>>>>>>>>> from my
>>>>>>>>>>>>> box to examine this?
>>>>>>>>>>>> What is the linux distribution on your machine? And use
>>>>>>>>>>>> showkey to
>>>>>>>>>>>> catch
>>>>>>>>>>>> the keycode of that button.
>>>>>>>>>>> I'm running OpenSUSE 13.1. The reported keycode of the power
>>>>>>>>>>> button is
>>>>>>>>>>> 116.
>>>>>>>>>> It seems the keycode is correct, it is power keycode rather
>>>>>>>>>> the mute
>>>>>>>>>> keycode.
>>>>>>>>>>
>>>>>>>>>> Could you please do some debug, let us find which line of code=
 is
>>>> the
>>>>>>>>>> root cause for this problem. for example:
>>>>>>>>>>
>>>>>>>>>> after running the line, the problem shows up:
>>>>>>>>>>
>>>>>>>>>> 1.     if (ACPI_SUCCESS(acpi_get_devices("LEN0068",
>>>>>>>>>> acpi_check_cb,
>>>>>>>>>> &found, NULL)) && found) // in the
>>>>>>>>>> sound/pci/hda/thinkpad_helper.c,
>>>>>>>>>> is_thinkpad()
>>>>>>>>> This evaluates to true
>>>>>>>>>
>>>>>>>>>> 2.     return ACPI_SUCCESS(acpi_get_devices("IBM0068",
>>>> acpi_check_cb,
>>>>>>>>>> &found, NULL)) && found; // same as above
>>>>>>>>>>
>>>>>>>>>> 3.         if (led_set_func(TPACPI_LED_MUTE, false) >=3D 0) {
>>>>>>>>>> //in the
>>>>>>>>>> sound/pci/hda/thinkpad_helper.c, hda_fixup_thinkpad_acpi()
>>>>>>>>> ...and this
>>>>>>>>>
>>>>>>>>>> 4. if (led_set_func(TPACPI_LED_MICMUTE, false) >=3D 0) { // sa=
me as
>>>>>>>>>> above
>>>>>>>>>>
>>>>>>>>> ...and this as well. spec->num_adc_nids is 1.
>>>>>>>> If we change the code like below, does the power button can work=

>>>>>>>> well?
>>>>>>>>
>>>>>>>> in the thinkpad_helper.c, hda_fixup_thinkpad_acpi()
>>>>>>>>
>>>>>>>>
>>>>>>>>           if (led_set_func(TPACPI_LED_MUTE, false) >=3D 0) {
>>>>>>>>               /*
>>>>>>>>               old_vmaster_hook =3D spec->vmaster_mute.hook;
>>>>>>>>               spec->vmaster_mute.hook =3D update_tpacpi_mute_led=
;
>>>>>>>>               removefunc =3D false;
>>>>>>>>              */
>>>>>>> Disabling only this block resolves the issue.
>>>>>> So Below two lines make the power button change to the reset butto=
n.
>>>>>>
>>>>>> drivers/platform/x86/thinkpad_acpi.c  mute_led_on_off():
>>>>>>
>>>>>> acpi_get_handle(hkey_handle, "SSMS", &temp);
>>>>>> acpi_evalf(hkey_handle, &output, "SSMS", "dd", 1);
>>>>>>
>>>>>>
>>>>>> @alexhung,
>>>>>> Do you have any idea why this can affect the power button behavior=
?
>>>>>>
>>>>> I think we all lost track of this issue, but it unfortunately still=

>>>>> exists in the latest kernel, requiring custom builds here. How can =
we
>>>>> proceed?
>>>> http://mailman.alsa-project.org/pipermail/alsa-devel/2015-May/091561=
=2Ehtml
>>>>
>>>>
>>>> If you cannot find "SSMS" in  your T520 ACPI dump, this mean mute LE=
D
>>>> cannot be turn on/off similar to T510
>>> There is an entry (see attached disassembly), but this device has at
>>> least no physical LED to drive.
> Some hotkey leds are embedded on button.  Through the pictures I found
> on the internet (thinkpad t520), it looks like there is a led at the
> center of the mute button.

Again, I'm on a X121e, and that has only a single physical LED for
signaling the power state. The mute button is behind key combination of
the keyboard.

Jan



--xQXeMThDWE7q28gpoIgwVUJrQ22x1XJDA
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEARECAAYFAlWL39QACgkQitSsb3rl5xTdtACg2GujAqUtrn2L//EBylZVWhU/
Y0YAn1f/3h0noj18rlhzRRNxdg07vNWC
=Bv36
-----END PGP SIGNATURE-----

--xQXeMThDWE7q28gpoIgwVUJrQ22x1XJDA--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/