Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751930AbbFYMRp (ORCPT <rfc822;w@1wt.eu>);
	Thu, 25 Jun 2015 08:17:45 -0400
Received: from mail-pd0-f176.google.com ([209.85.192.176]:36616 "EHLO
	mail-pd0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751637AbbFYMRi (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 25 Jun 2015 08:17:38 -0400
Date: Thu, 25 Jun 2015 17:47:29 +0530
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Juston Li <juston.h.li@gmail.com>
Cc: teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org,
        linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org, dan.carpenter@oracle.com
Subject: Re: [PATCH v3 16/19] staging: sm750fb: fix brace placement
Message-ID: <20150625121729.GD13366@sudip-PC>
References: <CAFow2F8Vgh93P5wmvDKcLCkiO2KkXQ14M1DXLhyeD6WTcH2RHg@mail.gmail.com>
 <1435163120-3253-16-git-send-email-juston.h.li@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1435163120-3253-16-git-send-email-juston.h.li@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 895
Lines: 27

On Wed, Jun 24, 2015 at 09:25:17AM -0700, Juston Li wrote:
> Fix brace placement errors caught by checkpatch.pl
> ERROR: that open brace { should be on the previous line
> 
> Signed-off-by: Juston Li <juston.h.li@gmail.com>
> ---
<snip>
> @@ -71,14 +66,11 @@ static void setDisplayControl(int ctrl, int dispState)
>  			POKE32(PANEL_DISPLAY_CTRL, ulDisplayCtrlReg);
>  		}
>  
> -	}
>  	/* Set the secondary display control */
> -	else
> -	{
> +	} else {
just a thought. The comment previously was at the beginning of the else
block, but now it will be placed inside the if block - at the end.
will it confuse code readers afterwards?

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/