Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751422AbbFYMgY (ORCPT ); Thu, 25 Jun 2015 08:36:24 -0400 Received: from mail-pa0-f51.google.com ([209.85.220.51]:35727 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751253AbbFYMgQ (ORCPT ); Thu, 25 Jun 2015 08:36:16 -0400 Message-ID: <558BF5B7.6070708@linaro.org> Date: Thu, 25 Jun 2015 18:06:07 +0530 From: Vaibhav Hiremath User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Krzysztof Kozlowski CC: Lee Jones , Zhao Ye , devicetree@vger.kernel.org, yizhang@marvell.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH-v4 2/3] mfd: 88pm800: Set default interrupt clear method References: <1435217189-19578-1-git-send-email-vaibhav.hiremath@linaro.org> <1435217189-19578-3-git-send-email-vaibhav.hiremath@linaro.org> <20150625102618.GC15013@x1> <558BE3D6.2010801@linaro.org> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3236 Lines: 97 On Thursday 25 June 2015 05:15 PM, Krzysztof Kozlowski wrote: > 2015-06-25 20:19 GMT+09:00 Vaibhav Hiremath : >> >> >> On Thursday 25 June 2015 03:56 PM, Lee Jones wrote: > > (...) > >>>> diff --git a/include/linux/mfd/88pm80x.h b/include/linux/mfd/88pm80x.h >>>> index 97cb283..94b3dcd 100644 >>>> --- a/include/linux/mfd/88pm80x.h >>>> +++ b/include/linux/mfd/88pm80x.h >>>> @@ -77,6 +77,8 @@ enum { >>>> #define PM800_WAKEUP2 (0x0E) >>>> #define PM800_WAKEUP2_INV_INT (1 << 0) >>>> #define PM800_WAKEUP2_INT_CLEAR (1 << 1) >>>> +#define PM800_WAKEUP2_INT_READ_CLEAR (0 << 1) >>>> +#define PM800_WAKEUP2_INT_WRITE_CLEAR (1 << 1) >>>> #define PM800_WAKEUP2_INT_MASK (1 << 2) >>> >>> >>> Use the BIT() macro. >>> >> >> I thought about this, but the whole file doesn't use it, so I also >> chose not to. >> >> >>>> #define PM800_POWER_UP_LOG (0x10) >>>> @@ -300,7 +302,7 @@ struct pm80x_chip { >>>> struct regmap_irq_chip_data *irq_data; >>>> int type; >>>> int irq; >>>> - int irq_mode; >>>> + int irq_clr_on_wr; /* '1': Clear on write, '0': Clear on >>>> read*/ >>> >>> >>> Whitespace issue. >>> >> >> Didn't see any...and I also ran checkpatch. >> >>> Shouldn't this be a bool? >>> >> >> Just was not sure about any older board file interface. >> Ideally it should be bool only. >> >>> Actually even better, I would define; CLR_ON_WRITE and CLR_ON_READ, >>> and call the variable irq_clear_method, or something. >>> >>> Much clearer that way I think. >>> >> >> We have slowly decided to almost hardcode it to one value if there is >> no board file. I feel we should just keep it to simple. >> >> If you still insist, I can implement. > > The bool would be indeed nicer and still you could hard-code the > desired value on DT system: > + /* by default, set irq clear method on write */ > + pdata->irq_clear_method = CLR_ON_WRITE; > > However the question is how this would influence existing platforms > using board files. Are there any in kernel or in downstream? > No, not atleast I am aware of. I did grep on mainline kernel, and here is what I got drivers/regulator/88pm800.c: struct pm80x_platform_data *pdata = dev_get_platdata(pdev->dev.parent); drivers/mfd/88pm800.c: struct pm80x_platform_data *pdata) drivers/mfd/88pm800.c: struct pm80x_platform_data *pdata) drivers/mfd/88pm800.c: struct pm80x_platform_data *pdata) drivers/mfd/88pm800.c: struct pm80x_platform_data *pdata) drivers/mfd/88pm800.c: struct pm80x_platform_data *pdata) drivers/mfd/88pm800.c: struct pm80x_platform_data *pdata = dev_get_platdata(&client->dev); drivers/mfd/88pm805.c: struct pm80x_platform_data *pdata = dev_get_platdata(&client->dev); include/linux/mfd/88pm80x.h:struct pm80x_platform_data { include/linux/mfd/88pm80x.h: struct pm80x_platform_data *pdata); Thanks, Vaibhav -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/